You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/16 09:02:12 UTC
[GitHub] [ignite-3] ibessonov opened a new pull request, #1011: IGNITE-17532 Removed explicit flush after partition deletion in RockDB based partition storage.
ibessonov opened a new pull request, #1011:
URL: https://github.com/apache/ignite-3/pull/1011
https://issues.apache.org/jira/browse/IGNITE-17532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov merged pull request #1011: IGNITE-17532 Removed explicit flush after partition deletion in RockDB based partition storage.
Posted by GitBox <gi...@apache.org>.
ibessonov merged PR #1011:
URL: https://github.com/apache/ignite-3/pull/1011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1011: IGNITE-17532 Removed explicit flush after partition deletion in RockDB based partition storage.
Posted by GitBox <gi...@apache.org>.
ibessonov commented on code in PR #1011:
URL: https://github.com/apache/ignite-3/pull/1011#discussion_r946669405
##########
modules/storage-rocksdb/src/test/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorageTest.java:
##########
@@ -97,15 +97,6 @@ public void setUp(
assertThat(((RocksDbDataStorageView) tableCfg.dataStorage().value()).dataRegion(), equalTo(DEFAULT_DATA_REGION_NAME));
- CompletableFuture<Void> changeEngineFuture = rocksDbEngineConfig.defaultRegion()
Review Comment:
Moved that into a String configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1011: IGNITE-17532 Removed explicit flush after partition deletion in RockDB based partition storage.
Posted by GitBox <gi...@apache.org>.
ibessonov commented on code in PR #1011:
URL: https://github.com/apache/ignite-3/pull/1011#discussion_r946669048
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java:
##########
@@ -223,10 +232,63 @@ public void start() throws StorageException {
}
}
+ /**
+ * Returns a future to wait next flush operation from the current point in time. Uses {@link RocksDB#getLatestSequenceNumber()} to
+ * achieve this.
+ *
+ * @param schedule {@code true} if {@link RocksDB#flush(FlushOptions)} should be explicitly triggerred in the near future.
+ *
+ * @see #scheduleFlush()
+ */
+ public CompletableFuture<Void> awaitFlush(boolean schedule) {
+ CompletableFuture<Void> future;
+
+ long dbSequenceNumber = db.getLatestSequenceNumber();
+
+ synchronized (this) {
Review Comment:
Laziness
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java:
##########
@@ -223,10 +232,63 @@ public void start() throws StorageException {
}
}
+ /**
+ * Returns a future to wait next flush operation from the current point in time. Uses {@link RocksDB#getLatestSequenceNumber()} to
+ * achieve this.
+ *
+ * @param schedule {@code true} if {@link RocksDB#flush(FlushOptions)} should be explicitly triggerred in the near future.
+ *
+ * @see #scheduleFlush()
+ */
+ public CompletableFuture<Void> awaitFlush(boolean schedule) {
+ CompletableFuture<Void> future;
+
+ long dbSequenceNumber = db.getLatestSequenceNumber();
+
+ synchronized (this) {
+ if (dbSequenceNumber <= latestPersistedSequenceNumber) {
+ return CompletableFuture.completedFuture(null);
+ }
+
+ future = flushFuturesBySequenceNumber.computeIfAbsent(dbSequenceNumber, l -> new CompletableFuture<>());
+ }
+
+ if (schedule) {
+ scheduleFlush();
+ }
+
+ return future;
+ }
+
+ /**
+ * Completes all futures in {@link #flushFuturesBySequenceNumber} up to a given sequence number.
+ */
+ void completeFutures(long sequenceNumber) {
+ synchronized (this) {
Review Comment:
Same reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1011: IGNITE-17532 Removed explicit flush after partition deletion in RockDB based partition storage.
Posted by GitBox <gi...@apache.org>.
tkalkirill commented on code in PR #1011:
URL: https://github.com/apache/ignite-3/pull/1011#discussion_r946647242
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java:
##########
@@ -223,10 +232,63 @@ public void start() throws StorageException {
}
}
+ /**
+ * Returns a future to wait next flush operation from the current point in time. Uses {@link RocksDB#getLatestSequenceNumber()} to
+ * achieve this.
+ *
+ * @param schedule {@code true} if {@link RocksDB#flush(FlushOptions)} should be explicitly triggerred in the near future.
+ *
+ * @see #scheduleFlush()
+ */
+ public CompletableFuture<Void> awaitFlush(boolean schedule) {
+ CompletableFuture<Void> future;
+
+ long dbSequenceNumber = db.getLatestSequenceNumber();
+
+ synchronized (this) {
+ if (dbSequenceNumber <= latestPersistedSequenceNumber) {
+ return CompletableFuture.completedFuture(null);
+ }
+
+ future = flushFuturesBySequenceNumber.computeIfAbsent(dbSequenceNumber, l -> new CompletableFuture<>());
+ }
+
+ if (schedule) {
+ scheduleFlush();
+ }
+
+ return future;
+ }
+
+ /**
+ * Completes all futures in {@link #flushFuturesBySequenceNumber} up to a given sequence number.
+ */
+ void completeFutures(long sequenceNumber) {
+ synchronized (this) {
Review Comment:
Why not mux?
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java:
##########
@@ -223,10 +232,63 @@ public void start() throws StorageException {
}
}
+ /**
+ * Returns a future to wait next flush operation from the current point in time. Uses {@link RocksDB#getLatestSequenceNumber()} to
+ * achieve this.
+ *
+ * @param schedule {@code true} if {@link RocksDB#flush(FlushOptions)} should be explicitly triggerred in the near future.
+ *
+ * @see #scheduleFlush()
+ */
+ public CompletableFuture<Void> awaitFlush(boolean schedule) {
+ CompletableFuture<Void> future;
+
+ long dbSequenceNumber = db.getLatestSequenceNumber();
+
+ synchronized (this) {
Review Comment:
Why not mux?
##########
modules/storage-rocksdb/src/test/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorageTest.java:
##########
@@ -97,15 +97,6 @@ public void setUp(
assertThat(((RocksDbDataStorageView) tableCfg.dataStorage().value()).dataRegion(), equalTo(DEFAULT_DATA_REGION_NAME));
- CompletableFuture<Void> changeEngineFuture = rocksDbEngineConfig.defaultRegion()
Review Comment:
Why remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org