[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10266: Add name case for ScalarFunction annotation for casewhen

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #10266:
URL: https://github.com/apache/pinot/pull/10266#discussion_r1103374329


##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ObjectFunctions.java:
##########
@@ -94,28 +94,28 @@ private static Object coalesceVar(Object... objects) {
     return null;
   }
 
-  @ScalarFunction
+  @ScalarFunction(nullableParameters = true, names = {"case", "caseWhen", "case_when"})
   public static Object caseWhen(boolean c1, Object o1, Object oe) {

Review Comment:
   Good catch on the `nullableParameters`. Can you please also annotate the object as `@Nullable`? Same for all functions, and we should also call it out in the PR description



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org