You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ga...@apache.org on 2019/09/27 12:39:28 UTC

[flink] 01/06: [hotfix][runtime] Make slotSharingGroupId nullable in TestingLogicalSlot

This is an automated email from the ASF dual-hosted git repository.

gary pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git

commit 96047a25d29c53106170e2be376be198c5a6b5c2
Author: Gary Yao <ga...@apache.org>
AuthorDate: Mon Sep 9 14:29:01 2019 +0200

    [hotfix][runtime] Make slotSharingGroupId nullable in TestingLogicalSlot
---
 .../java/org/apache/flink/runtime/jobmaster/TestingLogicalSlot.java  | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/TestingLogicalSlot.java b/flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/TestingLogicalSlot.java
index 3304c96..de67e41 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/TestingLogicalSlot.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/TestingLogicalSlot.java
@@ -53,6 +53,7 @@ public class TestingLogicalSlot implements LogicalSlot {
 
 	private final SlotRequestId slotRequestId;
 
+	@Nullable
 	private final SlotSharingGroupId slotSharingGroupId;
 
 	TestingLogicalSlot(
@@ -61,7 +62,7 @@ public class TestingLogicalSlot implements LogicalSlot {
 			int slotNumber,
 			AllocationID allocationId,
 			SlotRequestId slotRequestId,
-			SlotSharingGroupId slotSharingGroupId,
+			@Nullable SlotSharingGroupId slotSharingGroupId,
 			boolean automaticallyCompleteReleaseFuture,
 			SlotOwner slotOwner) {
 
@@ -71,7 +72,7 @@ public class TestingLogicalSlot implements LogicalSlot {
 		this.slotNumber = slotNumber;
 		this.allocationId = Preconditions.checkNotNull(allocationId);
 		this.slotRequestId = Preconditions.checkNotNull(slotRequestId);
-		this.slotSharingGroupId = Preconditions.checkNotNull(slotSharingGroupId);
+		this.slotSharingGroupId = slotSharingGroupId;
 		this.releaseFuture = new CompletableFuture<>();
 		this.automaticallyCompleteReleaseFuture = automaticallyCompleteReleaseFuture;
 		this.slotOwner = slotOwner;