You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/06/07 16:48:03 UTC

[GitHub] [calcite] a-rafay commented on pull request #2423: [CALCITE-4636] Switch out of agg mode when constructing RelCollation …

a-rafay commented on pull request #2423:
URL: https://github.com/apache/calcite/pull/2423#issuecomment-856097891


   > LGTM. does it only generates impact on your hypothetical query? or other queries are wrong as well ?
   
   @zinking the test case i fixed in this patch was wrong. So there might be other queries giving wrong results. I found one in my test case too, but it was very similar to the test case which i fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org