You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@commons.apache.org by dalbani <gi...@git.apache.org> on 2018/01/05 23:27:09 UTC

[GitHub] commons-compress pull request #56: [COMPRESS-429] Provide information about ...

Github user dalbani commented on a diff in the pull request:

    https://github.com/apache/commons-compress/pull/56#discussion_r160002542
  
    --- Diff: src/main/java/org/apache/commons/compress/archivers/zip/ZipUtil.java ---
    @@ -239,6 +239,7 @@ static void setNameAndCommentFromExtraFields(final ZipArchiveEntry ze,
                                                                originalNameBytes);
             if (newName != null && !originalName.equals(newName)) {
    --- End diff --
    
    When I think about it, I would remove the second test in this `if`, so that the Unicode field always have "priority" over the original name as source.
    Scenario where it would matter is when the `originalName` contains a non ASCII value (which is properly decoded) and which matches with the Unicode field value.


---