You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mihailom-db (via GitHub)" <gi...@apache.org> on 2024/04/11 19:38:31 UTC
[PR] [FOLLOWUP][SPARK-47541] Fix ANSI tests [spark]
mihailom-db opened a new pull request, #46016:
URL: https://github.com/apache/spark/pull/46016
### What changes were proposed in this pull request?
Fixing array_join.
### Why are the changes needed?
ANSI tests failing.
### Does this PR introduce _any_ user-facing change?
Yes
### How was this patch tested?
CollationSuite in both ANSI and non-ansi mode.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47541][SQL][FOLLOWUP] Fix `AnsiTypeCoercion` to handle ArrayType [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #46016: [SPARK-47541][SQL][FOLLOWUP] Fix `AnsiTypeCoercion` to handle ArrayType
URL: https://github.com/apache/spark/pull/46016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [FOLLOWUP][SPARK-47541] Fix ANSI tests [spark]
Posted by "mihailom-db (via GitHub)" <gi...@apache.org>.
mihailom-db commented on PR #46016:
URL: https://github.com/apache/spark/pull/46016#issuecomment-2050390369
Fix for https://github.com/apache/spark/pull/45693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [FOLLOWUP][SPARK-47541] Fix ANSI tests [spark]
Posted by "mihailom-db (via GitHub)" <gi...@apache.org>.
mihailom-db commented on PR #46016:
URL: https://github.com/apache/spark/pull/46016#issuecomment-2050504695
@dongjoon-hyun Could you merge this in to fix the broken tests in master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47541][SQL][FOLLOWUP] Fix ANSI tests [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #46016:
URL: https://github.com/apache/spark/pull/46016#discussion_r1561802563
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala:
##########
@@ -422,7 +422,8 @@ abstract class TypeCoercionBase {
case None => c
}
- case aj @ ArrayJoin(arr, d, nr) if !ArrayType(StringType).acceptsType(arr.dataType) &&
+ case aj @ ArrayJoin(arr, d, nr)
+ if !AbstractArrayType(StringTypeAnyCollation).acceptsType(arr.dataType) &&
Review Comment:
nit. We need two more spaces for indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47541][SQL][FOLLOWUP] Fix `AnsiTypeCoercion` to handle ArrayType [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #46016:
URL: https://github.com/apache/spark/pull/46016#issuecomment-2050791776
Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org