You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dpogue <gi...@git.apache.org> on 2017/01/11 19:04:40 UTC
[GitHub] cordova-ios pull request #287: Delete the correct build output folder
GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-ios/pull/287
Delete the correct build output folder
JIRA is down, so no JIRA ticket \U0001f64a
### Platforms affected
iOS (Simulator, mostly)
### What does this PR do?
Ensures that when building for the simulator, device builds are not deleted.
### What testing has been done on this change?
All unit tests passing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-ios build-dir-clean
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/287.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #287
----
commit 1a6c4edb527fcc9cbcaf43e299f5e8c117e335d4
Author: Darryl Pogue <da...@ayogo.com>
Date: 2017-01-11T18:59:20Z
Delete the correct build output folder
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #287: CB-12473 - Delete the correct build output folder
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/287
Added JIRA ticket reference
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #287: Delete the correct build output folder
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/287
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/287?src=pr) is 64.11% (diff: 0.00%)
> Merging [#287](https://codecov.io/gh/apache/cordova-ios/pull/287?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will not change coverage
```diff
@@ master #287 diff @@
==========================================
Files 12 12
Lines 1360 1360
Methods 208 208
Messages 0 0
Branches 229 230 +1
==========================================
Hits 872 872
Misses 488 488
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [6df46b7...1a6c4ed](https://codecov.io/gh/apache/cordova-ios/compare/6df46b7bad8da2f49560389a38a6d3929fabfe01...1a6c4edb527fcc9cbcaf43e299f5e8c117e335d4?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #287: CB-12473 - Delete the correct build output fo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/287
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #287: Delete the correct build output folder
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/287
Thanks @dpogue can you add that JIRA ticket now? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org