You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Felix Knecht <fe...@apache.org> on 2010/06/08 09:22:35 UTC

Re: svn commit: r952543 - in /directory/buildtools/trunk/junit-addons: ./ src/ src/main/ src/main/java/ src/main/java/org/ src/main/java/org/apache/ src/main/java/org/apache/directory/ src/main/java/org/apache/directory/junit/ src/main/java/org/apache/dire...

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

He says "The runners provided on this article demonstrates how to use a
custom RunnerScheduler, but can be safely used in any projects and be
modified according to your needs." (http://junit.org/node/589), so there
should be no problem adding the Apache license header. What about the
@author tag? Shall we leave it as it is (@author Mathieu Carbou
(mathieu.carbou@gmail.com)) or do we have to change it pointing to
dev@directory.apache.org?

Thanks
Felix

> Added: directory/buildtools/trunk/junit-addons/src/main/java/org/apache/directory/junit/tools/ConcurrentSuite.java
> URL: http://svn.apache.org/viewvc/directory/buildtools/trunk/junit-addons/src/main/java/org/apache/directory/junit/tools/ConcurrentSuite.java?rev=952543&view=auto
> ==============================================================================
> --- directory/buildtools/trunk/junit-addons/src/main/java/org/apache/directory/junit/tools/ConcurrentSuite.java (added)
> +++ directory/buildtools/trunk/junit-addons/src/main/java/org/apache/directory/junit/tools/ConcurrentSuite.java Tue Jun  8 05:55:19 2010
> @@ -0,0 +1,66 @@
> +/*
> + *  Licensed to the Apache Software Foundation (ASF) under one
> + *  or more contributor license agreements.  See the NOTICE file
> + *  distributed with this work for additional information
> + *  regarding copyright ownership.  The ASF licenses this file
> + *  to you under the Apache License, Version 2.0 (the
> + *  "License"); you may not use this file except in compliance
> + *  with the License.  You may obtain a copy of the License at
> + *  
> + *    http://www.apache.org/licenses/LICENSE-2.0
> + *  
> + *  Unless required by applicable law or agreed to in writing,
> + *  software distributed under the License is distributed on an
> + *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> + *  KIND, either express or implied.  See the License for the
> + *  specific language governing permissions and limitations
> + *  under the License. 
> + *  
> + */
> +package org.apache.directory.junit.tools;
> +
> +
> +import java.util.Arrays;
> +import java.util.List;
> +
> +import org.junit.internal.builders.AllDefaultPossibilitiesBuilder;
> +import org.junit.runner.Runner;
> +import org.junit.runners.Suite;
> +import org.junit.runners.model.InitializationError;
> +import org.junit.runners.model.RunnerBuilder;
> +
> +
> +/**
> + * @author Mathieu Carbou (mathieu.carbou@gmail.com)
> + */
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwN77sACgkQ2lZVCB08qHGtegCfZEO2w4G48SAmFR6QiXW8/hpa
wVoAn1phLb1Xadiq6Or6T5JasSk4qG3H
=igzM
-----END PGP SIGNATURE-----

Re: svn commit: r952543 - in /directory/buildtools/trunk/junit-addons: ./ src/ src/main/ src/main/java/ src/main/java/org/ src/main/java/org/apache/ src/main/java/org/apache/directory/ src/main/java/org/apache/directory/junit/ src/main/java/org/apache/dire...

Posted by Felix Knecht <fe...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/08/10 09:39, Emmanuel Lecharny wrote:
> On 6/8/10 9:22 AM, Felix Knecht wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> He says "The runners provided on this article demonstrates how to use a
>> custom RunnerScheduler, but can be safely used in any projects and be
>> modified according to your needs." (http://junit.org/node/589), so there
>> should be no problem adding the Apache license header. What about the
>> @author tag? Shall we leave it as it is (@author Mathieu Carbou
>> (mathieu.carbou@gmail.com)) or do we have to change it pointing to
>> dev@directory.apache.org?
>>    
> 
> FYI, I have sent a comment to Mathieu asking for some more information
> about these classes usage.

Much thanks for this.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwOAYEACgkQ2lZVCB08qHE54gCg454ElNzekEU5rYDYrFaWApNV
H0wAoIUJFwDJYkaKPeYXh8XY8kSCP+P3
=gcY/
-----END PGP SIGNATURE-----

Re: svn commit: r952543 - in /directory/buildtools/trunk/junit-addons: ./ src/ src/main/ src/main/java/ src/main/java/org/ src/main/java/org/apache/ src/main/java/org/apache/directory/ src/main/java/org/apache/directory/junit/ src/main/java/org/apache/dire...

Posted by Emmanuel Lecharny <el...@gmail.com>.
On 6/8/10 9:22 AM, Felix Knecht wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> He says "The runners provided on this article demonstrates how to use a
> custom RunnerScheduler, but can be safely used in any projects and be
> modified according to your needs." (http://junit.org/node/589), so there
> should be no problem adding the Apache license header. What about the
> @author tag? Shall we leave it as it is (@author Mathieu Carbou
> (mathieu.carbou@gmail.com)) or do we have to change it pointing to
> dev@directory.apache.org?
>    

FYI, I have sent a comment to Mathieu asking for some more information 
about these classes usage.

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.nextury.com



Re: svn commit: r952543 - in /directory/buildtools/trunk/junit-addons: ./ src/ src/main/ src/main/java/ src/main/java/org/ src/main/java/org/apache/ src/main/java/org/apache/directory/ src/main/java/org/apache/directory/junit/ src/main/java/org/apache/dire...

Posted by Emmanuel Lecharny <el...@gmail.com>.
On 6/8/10 10:37 AM, Felix Knecht wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 06/08/10 09:30, Emmanuel Lecharny wrote:
>    
>> On 6/8/10 9:22 AM, Felix Knecht wrote:
>>      
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> He says "The runners provided on this article demonstrates how to use a
>>> custom RunnerScheduler, but can be safely used in any projects and be
>>> modified according to your needs." (http://junit.org/node/589), so there
>>> should be no problem adding the Apache license header. What about the
>>> @author tag? Shall we leave it as it is (@author Mathieu Carbou
>>> (mathieu.carbou@gmail.com)) or do we have to change it pointing to
>>> dev@directory.apache.org?
>>>
>>>        
>> Atm, I'm afraid we have to think twice before using it : the jar is not
>> present in any maven repos, and the build is failing :/
>>      
> That's why I added a new module to the build-tools and added it to the
> trunk-with-dependencies project. Please update the
> trunk-with-dependencies and run mvn clean install on the trunk. It works
> for me and mvn clean install -Dintegration has no errors.
>    

My bad, I forgot to svn up the root of the project, where those modules 
are referenced.

Sorry for the noise.


-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.nextury.com



Re: svn commit: r952543 - in /directory/buildtools/trunk/junit-addons: ./ src/ src/main/ src/main/java/ src/main/java/org/ src/main/java/org/apache/ src/main/java/org/apache/directory/ src/main/java/org/apache/directory/junit/ src/main/java/org/apache/dire...

Posted by Felix Knecht <fe...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/08/10 09:30, Emmanuel Lecharny wrote:
> On 6/8/10 9:22 AM, Felix Knecht wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> He says "The runners provided on this article demonstrates how to use a
>> custom RunnerScheduler, but can be safely used in any projects and be
>> modified according to your needs." (http://junit.org/node/589), so there
>> should be no problem adding the Apache license header. What about the
>> @author tag? Shall we leave it as it is (@author Mathieu Carbou
>> (mathieu.carbou@gmail.com)) or do we have to change it pointing to
>> dev@directory.apache.org?
>>    
> Atm, I'm afraid we have to think twice before using it : the jar is not
> present in any maven repos, and the build is failing :/

That's why I added a new module to the build-tools and added it to the
trunk-with-dependencies project. Please update the
trunk-with-dependencies and run mvn clean install on the trunk. It works
for me and mvn clean install -Dintegration has no errors.

> Another option is to inject the code into our code base, with
> appropriate attribution.

I thought I did this with the module junit-addons?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwOAWYACgkQ2lZVCB08qHGbPACgtdLZe/IJi8l+oS/aSXQuBADL
3doAoN0tN7SkGLfim3XXKiEFv/ikJbq7
=WJtr
-----END PGP SIGNATURE-----

Re: svn commit: r952543 - in /directory/buildtools/trunk/junit-addons: ./ src/ src/main/ src/main/java/ src/main/java/org/ src/main/java/org/apache/ src/main/java/org/apache/directory/ src/main/java/org/apache/directory/junit/ src/main/java/org/apache/dire...

Posted by Emmanuel Lecharny <el...@gmail.com>.
On 6/8/10 9:22 AM, Felix Knecht wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> He says "The runners provided on this article demonstrates how to use a
> custom RunnerScheduler, but can be safely used in any projects and be
> modified according to your needs." (http://junit.org/node/589), so there
> should be no problem adding the Apache license header. What about the
> @author tag? Shall we leave it as it is (@author Mathieu Carbou
> (mathieu.carbou@gmail.com)) or do we have to change it pointing to
> dev@directory.apache.org?
>    
Atm, I'm afraid we have to think twice before using it : the jar is not 
present in any maven repos, and the build is failing :/

Another option is to inject the code into our code base, with 
appropriate attribution.


-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.nextury.com