You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2009/10/30 04:53:59 UTC

[jira] Created: (LUCENE-2021) French elision filter should use CharArraySet

French elision filter should use CharArraySet
---------------------------------------------

                 Key: LUCENE-2021
                 URL: https://issues.apache.org/jira/browse/LUCENE-2021
             Project: Lucene - Java
          Issue Type: Improvement
          Components: contrib/analyzers
            Reporter: Robert Muir
            Assignee: Robert Muir
            Priority: Trivial
             Fix For: 3.0
         Attachments: LUCENE-2021.patch

French elision filter creates new strings, lowercases them, etc just to check against a Set<String>.
trivial patch to use chararrayset instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-2021) French elision filter should use CharArraySet

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-2021.
---------------------------------

    Resolution: Fixed

Committed revision 831268.

> French elision filter should use CharArraySet
> ---------------------------------------------
>
>                 Key: LUCENE-2021
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2021
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Trivial
>             Fix For: 3.0
>
>         Attachments: LUCENE-2021.patch, LUCENE-2021.patch
>
>
> French elision filter creates new strings, lowercases them, etc just to check against a Set<String>.
> trivial patch to use chararrayset instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2021) French elision filter should use CharArraySet

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-2021:
--------------------------------

    Attachment: LUCENE-2021.patch

> French elision filter should use CharArraySet
> ---------------------------------------------
>
>                 Key: LUCENE-2021
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2021
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Trivial
>             Fix For: 3.0
>
>         Attachments: LUCENE-2021.patch
>
>
> French elision filter creates new strings, lowercases them, etc just to check against a Set<String>.
> trivial patch to use chararrayset instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2021) French elision filter should use CharArraySet

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-2021:
--------------------------------

    Attachment: LUCENE-2021.patch

do not create a new chararrayset in setArticles if the supplied set is already a chararrayset.

> French elision filter should use CharArraySet
> ---------------------------------------------
>
>                 Key: LUCENE-2021
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2021
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Trivial
>             Fix For: 3.0
>
>         Attachments: LUCENE-2021.patch, LUCENE-2021.patch
>
>
> French elision filter creates new strings, lowercases them, etc just to check against a Set<String>.
> trivial patch to use chararrayset instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-2021) French elision filter should use CharArraySet

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771779#action_12771779 ] 

Robert Muir commented on LUCENE-2021:
-------------------------------------

bq. The setArticles method could check with instanceof, if the supplied set is a chararrayset and use it directly (see StopFilter). Otherwise looks good.

good idea, I'll fix this.

> French elision filter should use CharArraySet
> ---------------------------------------------
>
>                 Key: LUCENE-2021
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2021
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Trivial
>             Fix For: 3.0
>
>         Attachments: LUCENE-2021.patch
>
>
> French elision filter creates new strings, lowercases them, etc just to check against a Set<String>.
> trivial patch to use chararrayset instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-2021) French elision filter should use CharArraySet

Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771776#action_12771776 ] 

Uwe Schindler commented on LUCENE-2021:
---------------------------------------

The setArticles method could check with instanceof, if the supplied set is a chararrayset and use it directly (see StopFilter). Otherwise looks good.

> French elision filter should use CharArraySet
> ---------------------------------------------
>
>                 Key: LUCENE-2021
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2021
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Trivial
>             Fix For: 3.0
>
>         Attachments: LUCENE-2021.patch
>
>
> French elision filter creates new strings, lowercases them, etc just to check against a Set<String>.
> trivial patch to use chararrayset instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org