[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #1785: Core: Fix invalidation of metadata tables in CachingCatalog

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #1785:
URL: https://github.com/apache/iceberg/pull/1785#discussion_r526422600



##########
File path: core/src/main/java/org/apache/iceberg/CachingCatalog.java
##########
@@ -126,20 +128,36 @@ public Transaction newReplaceTableTransaction(TableIdentifier ident, Schema sche
     // when the transaction commits, invalidate the table in the cache if it is present.
     return CommitCallbackTransaction.addCallback(
         catalog.newReplaceTableTransaction(ident, schema, spec, location, properties, orCreate),
-        () -> tableCache.invalidate(canonicalizeIdentifier(ident)));
+        () -> invalidate(canonicalizeIdentifier(ident)));
   }
 
   @Override
   public boolean dropTable(TableIdentifier ident, boolean purge) {
     boolean dropped = catalog.dropTable(ident, purge);
-    tableCache.invalidate(canonicalizeIdentifier(ident));
+    invalidate(canonicalizeIdentifier(ident));
     return dropped;
   }
 
   @Override
   public void renameTable(TableIdentifier from, TableIdentifier to) {
     catalog.renameTable(from, to);

Review comment:
       If we alter table properties (to change metadata partitioning for example) do we want to invalidate in that case as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org