You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Tsz-wo Sze (Jira)" <ji...@apache.org> on 2024/08/26 18:16:00 UTC

[jira] [Resolved] (RATIS-2132) Revert RATIS-2099 due to its performance regression

     [ https://issues.apache.org/jira/browse/RATIS-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz-wo Sze resolved RATIS-2132.
-------------------------------
    Resolution: Done

Reverted RATIS-2099 and RATIS-2101.  Thanks, [~duongnguyen] for reporting this!
{code}
commit 520ecab157c9c6aff87ed5c5978c08f98cd4ec6c (origin/master, origin/HEAD, master)
Author: Tsz-Wo Nicholas Sze <sz...@apache.org>
Date:   Mon Aug 26 11:07:29 2024 -0700

    Revert "RATIS-2099. Cache TermIndexImpl instead of using anonymous class (#1100)"
    
    This reverts commit 428ce4ae3d5a0349f3425cb85ef1a3d38dea24b1.
{code}
{code}
commit da5d508caffc4ca90b0ab962b5105785b9774daa
Author: Tsz-Wo Nicholas Sze <sz...@apache.org>
Date:   Mon Aug 26 11:07:17 2024 -0700

    Revert "RATIS-2101. Move TermIndex.PRIVATE_CACHE to Util.CACHE (#1103)"
    
    This reverts commit 93eb32a8620fdd4e5119592ef32bc50590810c7b.
{code}


> Revert RATIS-2099 due to its performance regression
> ---------------------------------------------------
>
>                 Key: RATIS-2132
>                 URL: https://issues.apache.org/jira/browse/RATIS-2132
>             Project: Ratis
>          Issue Type: Sub-task
>            Reporter: Duong
>            Assignee: Duong
>            Priority: Major
>         Attachments: Screenshot 2024-07-29 at 5.07.32 PM.png
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> This commit creates a significant extra cost in the critical path (which is run sequentially) of Ratis appendTransaction. 
> !Screenshot 2024-07-29 at 5.07.32 PM.png|width=981,height=479!
> This seems to be a premature optimization. One or two instances of TermIndex per request are basically nothing (unless we create hundreds/thousands of them per request).   Short-lived POJO like this are the best to be dealt with by java GC/heap.
> More details are the parent Jira RATIS-2129.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)