Re: Review Request: HIVE-4588: Support session level hooks for HiveServer2

[Shreepadma Venugopalan <sh...@cloudera.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11326/#review21599
-----------------------------------------------------------


LGTM!

- Shreepadma Venugopalan


On May 22, 2013, 6:41 a.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11326/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 6:41 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Description
> -------
> 
> Support session level hooks for HiveServer2
>   - New config parameter to define the hook
>   - New hook context interface to pass the serssion user and config to the hook implementation
>   - Session manager executes the configured hooks when a new session starts
> 
> 
> This addresses bug HIVE-4588.
>     https://issues.apache.org/jira/browse/HIVE-4588
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 335af45 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionHook.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionHookContext.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionHookContextImpl.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 3bb6807 
>   service/src/test/org/apache/hive/service/cli/session/TestSessionHooks.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11326/diff/
> 
> 
> Testing
> -------
> 
> Added new test for session hooks
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>