[GitHub] [apisix] tokers commented on a diff in pull request #7168: fix(proxy-cache): allow nil ctx vars in cache key

[GitBox <gi...@apache.org>]

tokers commented on code in PR #7168:
URL: https://github.com/apache/apisix/pull/7168#discussion_r886239681


##########
docs/en/latest/plugins/proxy-cache.md:
##########
@@ -53,6 +53,8 @@ The cache expiration time cannot be configured dynamically. It can only be set b
 
 If the Upstream service is not available and APISIX returns a 502 or 504 status code, it will be cached for 10s.
 
+Variable starts with `$` and will be treated as an empty string when does not exist. You can also use a combination of variables and strings, but you need to write them separately in one array, and eventually the variables will be parsed and stitched together with strings.

Review Comment:
   ```suggestion
   Variables  (start with `$`) can be specified in `cache_key` and `cache_bypass. It's worth to mention that the variable value will be an empty string if it doesn't exist.
   
   You can also combine a number of variables and strings (constants), by writing them into an array, eventually, variables will be parsed and stitched together with strings.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org