You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2007/01/21 00:54:29 UTC

[jira] Created: (DIRSERVER-832) Added Attributes are all case sensitive

Added Attributes are all case sensitive
---------------------------------------

                 Key: DIRSERVER-832
                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
             Project: Directory ApacheDS
          Issue Type: Bug
    Affects Versions: 1.0, 1.5.0
            Reporter: Emmanuel Lecharny
            Priority: Blocker


The server is working, but this is pure luck !

When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
...
    private int getSubentryTypes( Attributes subentry ) throws NamingException
    {
        int types = 0;
        
        Attribute oc = subentry.get( "objectClass" );
        
        if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
...

At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.

I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Karasulu reassigned DIRSERVER-832:
---------------------------------------

    Assignee: Emmanuel Lecharny  (was: Alex Karasulu)

Giving this one to you Emmanuel.  I found the cause of this issue to be due to the premature normalization of Rdn types in a ATAV.  Here's a more specific test case that catches the problem:

http://svn.apache.org/viewvc?view=rev&revision=511071

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>         Assigned To: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Karasulu reassigned DIRSERVER-832:
---------------------------------------

    Assignee: Alex Karasulu

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>         Assigned To: Alex Karasulu
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny updated DIRSERVER-832:
----------------------------------------

    Fix Version/s:     (was: 1.5.3)
                   2.0.0

The new API should take care of this issue. However, I would like to keep it open until we do a code review.

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>            Assignee: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 2.0.0
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pierre-Arnaud Marcelot updated DIRSERVER-832:
---------------------------------------------

    Fix Version/s: 2.0.0-RC1
                       (was: 2.0.0)

Moving issue to 2.0.0-RC1.

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>            Assignee: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 2.0.0-RC1
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny updated DIRSERVER-832:
----------------------------------------

    Fix Version/s:     (was: 1.5.2)
                   1.5.3

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>            Assignee: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 1.5.3
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny closed DIRSERVER-832.
---------------------------------------


We are done with this issue

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>            Assignee: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 2.0.0
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623337#action_12623337 ] 

Emmanuel Lecharny commented on DIRSERVER-832:
---------------------------------------------

This has been fixed thanks to the new ServerEntry API. We don't use anymore Attribnute inside the server.

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>            Assignee: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 2.0.0
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475447 ] 

Alex Karasulu commented on DIRSERVER-832:
-----------------------------------------

Note that this loss of case only occurs with RDN attributes because on the reliance on LdapDN for generating the RDN within the server side JNDI provider.  I could hook up a work around but maybe it's best we fix the root of this issue first. 

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>         Assigned To: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606176#action_12606176 ] 

Alex Karasulu commented on DIRSERVER-832:
-----------------------------------------

Request for status.

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>            Assignee: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 1.5.3
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583864#action_12583864 ] 

Emmanuel Lecharny commented on DIRSERVER-832:
---------------------------------------------

The issue can almost be closed, now that we don't use anymore Attributes but ServerAttributes. But we still have to check that it's done correctly.

Postponed to 1.5.3

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>            Assignee: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 1.5.3
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475442 ] 

Alex Karasulu commented on DIRSERVER-832:
-----------------------------------------

This bug is still present.  The bug is not present in 1.0.1 but in 1.5.0 and should be fixed immediately because it's just annoying.  Here's a link to the test case that was added confirming the presence of the bug:

http://svn.apache.org/viewvc?view=rev&revision=511059



> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>         Assigned To: Alex Karasulu
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny resolved DIRSERVER-832.
-----------------------------------------

    Resolution: Fixed

Fixed

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>            Assignee: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 2.0.0
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481834 ] 

Emmanuel Lecharny commented on DIRSERVER-832:
---------------------------------------------

I have started to fix this one, and it will take time.

Here is what is going to happen :
- I will remove all the String reference to LDAP objectClasses and Attributes out of the code : no more "objectClass", "top" or whatever. Those String will now be constants declared in the shared-ldap-constants.
- these Strings won't be removed from tests : this is dangerous, as we may have to test that "TOP" or "top" is accepted by the server. Tester know what they are doing :)
- The apacheds-constants will get purged from the constants declared in shared-ldap. The apacheds-constants will only contians specific constants for apacheds, like meta-schema constants
- inside the server, developpers should *not* use direct access to attribute's values like shown in the initial bug report. Instead, they should use the AttributeUtils.containsValue() for this purpose (in shared-ldap).  This method use the registry to allow comparizons based on the defined matching rules for each attributes.

That's it ...

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>         Assigned To: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny updated DIRSERVER-832:
----------------------------------------

    Fix Version/s:     (was: 1.5.1)
                   1.5.2

Postponed to 1.5.2, as we will have to seriously modify the way we address the schema. I have started adding TODO Fix DIRSERVER-832 in the code each time there is a potential pb related to this issue.

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>            Assignee: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 1.5.2
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny updated DIRSERVER-832:
----------------------------------------

    Fix Version/s: 1.5.0

This bug won't be fixed in 1.0.1

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRSERVER-832) Added Attributes are all case sensitive

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny updated DIRSERVER-832:
----------------------------------------

    Fix Version/s:     (was: 1.5.0)
                   1.5.1

Postponed to 1.5.0

> Added Attributes are all case sensitive
> ---------------------------------------
>
>                 Key: DIRSERVER-832
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-832
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.0
>            Reporter: Emmanuel Lecharny
>         Assigned To: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 1.5.1
>
>
> The server is working, but this is pure luck !
> When we add some attribute, like ObjectClass, the values are added into it caseSensitive.
> For instance, adding 'person' and 'PERSON' is just adding two values into the attribute.
> So far, so good. Now, we have many places in the server where wo do case sensitive comparizon on suposely case insensitive values (like for objectclasses). For instance, in SchemService :
> ...
>     private int getSubentryTypes( Attributes subentry ) throws NamingException
>     {
>         int types = 0;
>         
>         Attribute oc = subentry.get( "objectClass" );
>         
>         if ( oc.contains( "accessControlSubentry" ) ) <<<--------------- This is DAMN WRONG !!!
> ...
> At this point, I suspect the 1.0.0 version is not amendable. We must fix it in 1.5, using the MatchingRules to manage comparizons on attributes.
> I hope I'm totally wrong, but I'm really scared... It looks like you go to the doctor wor that little red spot on your skin, and it turns out you have a hopeless cancer ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.