[GitHub] michellethomas opened a new pull request #6358: Fixing sort issue with area chart and adding tests

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #6358: Fixing sort issue with area chart and adding tests
URL: https://github.com/apache/incubator-superset/pull/6358
 
 
   There's an issue where the area (stacked line) chart doesn't sort correctly. At the end of get_data for NVD3 charts the data gets sorted. I asked Beto about this line added [here](https://github.com/apache/incubator-superset/pull/5177#discussion_r207693050) and it looks like it's necessary for time shift coloring. I believe the correct way to handle this is to see if the chart sorts the series (with `self.sort_series` flag), but I'm not sure if I'm missing any edge cases.
   
   I've added tests to make sure the area chart is sorted correctly, and make sure the line chart with time shift has the correct colors.
   
   Looks related to #6052

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org