You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/24 12:34:24 UTC

[GitHub] [airflow] potiuk opened a new pull request #18496: Add more informative messages when rebuilding the image

potiuk opened a new pull request #18496:
URL: https://github.com/apache/airflow/pull/18496


   Reviewed and updated the messages printed when image needed to
   be rebuild. Some messages were unclear or duplicatd. I removed
   all the ambiguities and added some colors. Also there was
   apparently the case that automated rebuild on commit did not take
   into account the check of whethere image needs to be pulled, that
   could lead to longer rebuild times in this case.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #18496: Add more informative messages when rebuilding the image

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18496:
URL: https://github.com/apache/airflow/pull/18496


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #18496: Add more informative messages when rebuilding the image

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18496:
URL: https://github.com/apache/airflow/pull/18496#issuecomment-926591300


   Pre-commit:
   
   ![image](https://user-images.githubusercontent.com/595491/134675068-c4e3a3e4-4c17-41c7-8512-e3f37c5efb9c.png)
   
   The `./breeze` command:
   
   ![image](https://user-images.githubusercontent.com/595491/134675215-3234e03f-f64c-447b-a07a-3bd0e5069180.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #18496: Add more informative messages when rebuilding the image

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #18496:
URL: https://github.com/apache/airflow/pull/18496#issuecomment-926591300


   Pre-commit:
   
   ![image](https://user-images.githubusercontent.com/595491/134675068-c4e3a3e4-4c17-41c7-8512-e3f37c5efb9c.png)
   
   The `./breeze` command:
   
   ![image](https://user-images.githubusercontent.com/595491/134675782-95a218d4-6a1f-465f-ad6f-0dec4aef06d2.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org