You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2012/06/07 01:15:23 UTC
[jira] [Created] (HADOOP-8488) when Jenkins tests a patch, it
should compile with -Pnative
Colin Patrick McCabe created HADOOP-8488:
--------------------------------------------
Summary: when Jenkins tests a patch, it should compile with -Pnative
Key: HADOOP-8488
URL: https://issues.apache.org/jira/browse/HADOOP-8488
Project: Hadoop Common
Issue Type: Improvement
Reporter: Colin Patrick McCabe
Priority: Minor
It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
Currently, we don't seem to build the native code at all when testing patches. Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs). However, some testing is sure better than none. I believe with cmake the performance overhead of -Pnative should be very minimal.
This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8488) when Jenkins tests a patch, it
should compile with -Pnative
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290614#comment-13290614 ]
Eli Collins commented on HADOOP-8488:
-------------------------------------
I believe it does, see ./dev-support/test-patch.sh. Perhaps it's running and the errors are getting ignored.
> when Jenkins tests a patch, it should compile with -Pnative
> ------------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Colin Patrick McCabe
> Priority: Minor
>
> It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
> Currently, we don't seem to build the native code at all when testing patches. Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
> It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs). However, some testing is sure better than none. I believe with cmake the performance overhead of -Pnative should be very minimal.
> This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8488:
-----------------------------------------
Description: It seems that Jenkins doesn't fail the build if the native part of the build doesn't succeed. This should be fixed! (was: It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
Currently, we don't seem to build the native code at all when testing patches. Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs). However, some testing is sure better than none. I believe with cmake the performance overhead of -Pnative should be very minimal.
This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.
)
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8488.001.patch
>
>
> It seems that Jenkins doesn't fail the build if the native part of the build doesn't succeed. This should be fixed!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8488:
-----------------------------------------
Issue Type: Bug (was: Improvement)
Summary: test-patch.sh gives +1 even if the native build fails. (was: when Jenkins tests a patch, it should compile with -Pnative )
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Priority: Minor
>
> It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
> Currently, we don't seem to build the native code at all when testing patches. Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
> It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs). However, some testing is sure better than none. I believe with cmake the performance overhead of -Pnative should be very minimal.
> This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291501#comment-13291501 ]
Hudson commented on HADOOP-8488:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2334 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2334/])
HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HADOOP-8488.001.patch
>
>
> It seems that Jenkins doesn't fail the build if the native part of the build doesn't succeed. This should be fixed!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8488:
-----------------------------------------
Attachment: HADOOP-8488.001.patch
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8488.001.patch
>
>
> It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
> Currently, we don't seem to build the native code at all when testing patches. Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
> It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs). However, some testing is sure better than none. I believe with cmake the performance overhead of -Pnative should be very minimal.
> This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291459#comment-13291459 ]
Eli Collins commented on HADOOP-8488:
-------------------------------------
+1 looks good
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8488.001.patch
>
>
> It seems that Jenkins doesn't fail the build if the native part of the build doesn't succeed. This should be fixed!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed HADOOP-8488.
---------------------------------
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.2-alpha
>
> Attachments: HADOOP-8488.001.patch
>
>
> It seems that Jenkins doesn't fail the build if the native part of the build doesn't succeed. This should be fixed!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291506#comment-13291506 ]
Hudson commented on HADOOP-8488:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2407 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2407/])
HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HADOOP-8488.001.patch
>
>
> It seems that Jenkins doesn't fail the build if the native part of the build doesn't succeed. This should be fixed!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291495#comment-13291495 ]
Hudson commented on HADOOP-8488:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2353 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2353/])
HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HADOOP-8488.001.patch
>
>
> It seems that Jenkins doesn't fail the build if the native part of the build doesn't succeed. This should be fixed!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291771#comment-13291771 ]
Hudson commented on HADOOP-8488:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1104 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1104/])
HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HADOOP-8488.001.patch
>
>
> It seems that Jenkins doesn't fail the build if the native part of the build doesn't succeed. This should be fixed!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8488) when Jenkins tests a patch, it
should compile with -Pnative
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290629#comment-13290629 ]
Colin Patrick McCabe commented on HADOOP-8488:
----------------------------------------------
Sorry if my comment was confusingly worded (too many negatives?). I meant "we use -fn to make sure we run all tests if possible"
> when Jenkins tests a patch, it should compile with -Pnative
> ------------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Colin Patrick McCabe
> Priority: Minor
>
> It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
> Currently, we don't seem to build the native code at all when testing patches. Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
> It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs). However, some testing is sure better than none. I believe with cmake the performance overhead of -Pnative should be very minimal.
> This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291198#comment-13291198 ]
Hadoop QA commented on HADOOP-8488:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12531282/HADOOP-8488.001.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1093//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1093//console
This message is automatically generated.
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8488.001.patch
>
>
> It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
> Currently, we don't seem to build the native code at all when testing patches. Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
> It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs). However, some testing is sure better than none. I believe with cmake the performance overhead of -Pnative should be very minimal.
> This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-8488:
--------------------------------
Resolution: Fixed
Fix Version/s: 2.0.1-alpha
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I've committed this and merged to branch-2. Thanks Colin.
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HADOOP-8488.001.patch
>
>
> It seems that Jenkins doesn't fail the build if the native part of the build doesn't succeed. This should be fixed!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291721#comment-13291721 ]
Hudson commented on HADOOP-8488:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1071 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1071/])
HADOOP-8488. test-patch.sh gives +1 even if the native build fails. Contributed by Colin Patrick McCabe (Revision 1347846)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347846
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HADOOP-8488.001.patch
>
>
> It seems that Jenkins doesn't fail the build if the native part of the build doesn't succeed. This should be fixed!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8488:
-----------------------------------------
Assignee: Colin Patrick McCabe
Status: Patch Available (was: Open)
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8488.001.patch
>
>
> It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
> Currently, we don't seem to build the native code at all when testing patches. Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
> It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs). However, some testing is sure better than none. I believe with cmake the performance overhead of -Pnative should be very minimal.
> This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira