[GitHub] [arrow] js8544 commented on a diff in pull request #15208: GH-15209: [C++][Gandiva] Add abs function

["js8544 (via GitHub)" <gi...@apache.org>]

js8544 commented on code in PR #15208:
URL: https://github.com/apache/arrow/pull/15208#discussion_r1117859065


##########
cpp/src/gandiva/precompiled/arithmetic_ops.cc:
##########
@@ -494,6 +494,18 @@ SIGN(float32)
 SIGN(float64)
 
 #undef SIGN
+
+#define ABS(TYPE) \
+  FORCE_INLINE    \
+  gdv_##TYPE abs_##TYPE(gdv_##TYPE in1) { return static_cast<gdv_##TYPE>(std::abs(in1)); }

Review Comment:
   > I think no, but then again it is there in all of the similar functions. Should I remove it from here only?
   
   I see. Then there's no harm to keep it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org