You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2014/02/13 00:29:24 UTC

Review Request 18037: OOZIE-1691 StackOverflowError in TimestampedMessageParser.parseNextLine()

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18037/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-1691
    https://issues.apache.org/jira/browse/OOZIE-1691


Repository: oozie-git


Description
-------

OOZIE-1691 StackOverflowError in TimestampedMessageParser.parseNextLine()


Diffs
-----

  core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 92a687b 
  core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java 55a5284 

Diff: https://reviews.apache.org/r/18037/diff/


Testing
-------


Thanks,

Purshotam Shah


Re: Review Request 18037: OOZIE-1691 StackOverflowError in TimestampedMessageParser.parseNextLine()

Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18037/#review34386
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Kanter


On Feb. 13, 2014, 2:25 a.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18037/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 2:25 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1691
>     https://issues.apache.org/jira/browse/OOZIE-1691
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> OOZIE-1691 StackOverflowError in TimestampedMessageParser.parseNextLine()
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 92a687b 
>   core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java 55a5284 
> 
> Diff: https://reviews.apache.org/r/18037/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>


Re: Review Request 18037: OOZIE-1691 StackOverflowError in TimestampedMessageParser.parseNextLine()

Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18037/
-----------------------------------------------------------

(Updated Feb. 13, 2014, 2:25 a.m.)


Review request for oozie.


Bugs: OOZIE-1691
    https://issues.apache.org/jira/browse/OOZIE-1691


Repository: oozie-git


Description
-------

OOZIE-1691 StackOverflowError in TimestampedMessageParser.parseNextLine()


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 92a687b 
  core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java 55a5284 

Diff: https://reviews.apache.org/r/18037/diff/


Testing
-------


Thanks,

Purshotam Shah


Re: Review Request 18037: OOZIE-1691 StackOverflowError in TimestampedMessageParser.parseNextLine()

Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18037/#review34331
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java
<https://reviews.apache.org/r/18037/#comment64382>

    Moving this into while could be  cleaner approach. Line 136 will also go away.
    


- Mohammad Islam


On Feb. 12, 2014, 11:29 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18037/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 11:29 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1691
>     https://issues.apache.org/jira/browse/OOZIE-1691
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> OOZIE-1691 StackOverflowError in TimestampedMessageParser.parseNextLine()
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 92a687b 
>   core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java 55a5284 
> 
> Diff: https://reviews.apache.org/r/18037/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>