You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by rf...@apache.org on 2006/08/29 10:00:16 UTC

svn commit: r438000 - in /incubator/tuscany/java/sca/core/src: main/java/org/apache/tuscany/core/loader/ComponentLoader.java test/java/org/apache/tuscany/core/loader/ComponentLoaderTestCase.java

Author: rfeng
Date: Tue Aug 29 01:00:16 2006
New Revision: 438000

URL: http://svn.apache.org/viewvc?rev=438000&view=rev
Log:
Make sure the StAX loading only ends upon </component>

Modified:
    incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/loader/ComponentLoader.java
    incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/loader/ComponentLoaderTestCase.java

Modified: incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/loader/ComponentLoader.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/loader/ComponentLoader.java?rev=438000&r1=437999&r2=438000&view=diff
==============================================================================
--- incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/loader/ComponentLoader.java (original)
+++ incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/loader/ComponentLoader.java Tue Aug 29 01:00:16 2006
@@ -113,7 +113,8 @@
                         reader.next();
                         break;
                     case END_ELEMENT:
-                        return componentDefinition;
+                        if(reader.getName().equals(COMPONENT))
+                            return componentDefinition;
                 }
             }
         } catch (LoaderException e) {

Modified: incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/loader/ComponentLoaderTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/loader/ComponentLoaderTestCase.java?rev=438000&r1=437999&r2=438000&view=diff
==============================================================================
--- incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/loader/ComponentLoaderTestCase.java (original)
+++ incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/loader/ComponentLoaderTestCase.java Tue Aug 29 01:00:16 2006
@@ -57,7 +57,7 @@
     private ComponentLoader loader;
 
     public void testEmptyComponent() throws LoaderException, XMLStreamException {
-        mockReader.expects(once()).method("getName").will(returnValue(COMPONENT));
+        mockReader.expects(atLeastOnce()).method("getName").will(returnValue(COMPONENT));
         mockReader.expects(atLeastOnce()).method("getAttributeValue")
             .with(ANYTHING, ANYTHING)
             .will(onConsecutiveCalls(returnValue(NAME), returnValue(null)));
@@ -71,7 +71,7 @@
     }
 
     public void testInitValue20() throws LoaderException, XMLStreamException {
-        mockReader.expects(once()).method("getName").will(returnValue(COMPONENT));
+        mockReader.expects(atLeastOnce()).method("getName").will(returnValue(COMPONENT));
         mockReader.expects(atLeastOnce()).method("getAttributeValue")
             .with(ANYTHING, ANYTHING)
             .will(onConsecutiveCalls(returnValue(NAME), returnValue("20")));



---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org


Re: svn commit: r438000

Posted by Venkata Krishnan <fo...@gmail.com>.
Hi,

I faced the same problem and configured my eclipse.  But then when you
reduce this you might also want to take care of how the line wrapping is
done.  For example the method signatures get wrapped without any alignment
and looked a bit clumsy.  I then set alignment of arguments and it looked a
little better after that.

- Venkat

On 8/30/06, Jim Marino <jm...@myromatours.com> wrote:
>
> I think it should be the checkstyle. The widest we ever went was 140
> and we had a discussion on several occasions where some wanted it
> smaller (e.g. 80), some larger, and some didn't care. 120 seems to be
> a reasonable length. Do you want to update the Eclipse one?
>
> Jim
>
> On Aug 29, 2006, at 5:03 PM, Raymond Feng wrote:
>
> > Hi,
> >
> > The rules from checkstlye are quite different than the IDE code
> > formatter templates we were recommending. For example, the template
> > for Eclipse sets the maximum characters per line to 150 while the
> > checkstyle complains at 120.
> >
> > Which one should we follow? If it's the checkstyle, then we should
> > update the IDE templates so that we are not confused.
> >
> > Thanks,
> > Raymond
> >
> > ----- Original Message ----- From: "Jim Marino"
> > <jm...@myromatours.com>
> > To: <tu...@ws.apache.org>
> > Sent: Tuesday, August 29, 2006 1:12 AM
> > Subject: Fwd: svn commit: r438000
> >
> >
> >> Hi Raymond,
> >>
> >> Could you please make sure you format this code: mvn -
> >> Psourcecheck?  It breaks Checkstyle.
> >>
> >> Thanks,
> >> Jim
> >>
> >> Begin forwarded message:
> >>
> >>> From: rfeng@apache.org
> >>> Date: August 29, 2006 1:00:16 AM PDT
> >>> To: tuscany-commits@ws.apache.org
> >>> Subject: svn commit: r438000 - in /incubator/tuscany/java/sca/
> >>> core/ src: main/java/org/apache/tuscany/core/loader/
> >>> ComponentLoader.java test/java/org/apache/tuscany/core/loader/
> >>> ComponentLoaderTestCase.java
> >>> Reply-To: tuscany-dev@ws.apache.org
> >>>
> >>> Author: rfeng
> >>> Date: Tue Aug 29 01:00:16 2006
> >>> New Revision: 438000
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=438000&view=rev
> >>> Log:
> >>> Make sure the StAX loading only ends upon </component>
> >>>
> >>> Modified:
> >>>     incubator/tuscany/java/sca/core/src/main/java/org/apache/
> >>> tuscany/core/loader/ComponentLoader.java
> >>>     incubator/tuscany/java/sca/core/src/test/java/org/apache/
> >>> tuscany/core/loader/ComponentLoaderTestCase.java
> >>>
> >>> Modified: incubator/tuscany/java/sca/core/src/main/java/org/
> >>> apache/ tuscany/core/loader/ComponentLoader.java
> >>> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/
> >>> core/ src/main/java/org/apache/tuscany/core/loader/
> >>> ComponentLoader.java? rev=438000&r1=437999&r2=438000&view=diff
> >>> ====================================================================
> >>> == ========
> >>> --- incubator/tuscany/java/sca/core/src/main/java/org/apache/
> >>> tuscany/core/loader/ComponentLoader.java (original)
> >>> +++ incubator/tuscany/java/sca/core/src/main/java/org/apache/
> >>> tuscany/core/loader/ComponentLoader.java Tue Aug 29 01:00:16 2006
> >>> @@ -113,7 +113,8 @@
> >>>                          reader.next();
> >>>                          break;
> >>>                      case END_ELEMENT:
> >>> -                        return componentDefinition;
> >>> +                        if(reader.getName().equals(COMPONENT))
> >>> +                            return componentDefinition;
> >>>                  }
> >>>              }
> >>>          } catch (LoaderException e) {
> >>>
> >>> Modified: incubator/tuscany/java/sca/core/src/test/java/org/
> >>> apache/ tuscany/core/loader/ComponentLoaderTestCase.java
> >>> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/
> >>> core/ src/test/java/org/apache/tuscany/core/loader/
> >>> ComponentLoaderTestCase.java?
> >>> rev=438000&r1=437999&r2=438000&view=diff
> >>> ====================================================================
> >>> == ========
> >>> --- incubator/tuscany/java/sca/core/src/test/java/org/apache/
> >>> tuscany/core/loader/ComponentLoaderTestCase.java (original)
> >>> +++ incubator/tuscany/java/sca/core/src/test/java/org/apache/
> >>> tuscany/core/loader/ComponentLoaderTestCase.java Tue Aug 29
> >>> 01:00:16 2006
> >>> @@ -57,7 +57,7 @@
> >>>      private ComponentLoader loader;
> >>>
> >>>      public void testEmptyComponent() throws LoaderException,
> >>> XMLStreamException {
> >>> -        mockReader.expects(once()).method("getName").will
> >>> (returnValue(COMPONENT));
> >>> +        mockReader.expects(atLeastOnce()).method("getName").will
> >>> (returnValue(COMPONENT));
> >>>          mockReader.expects(atLeastOnce()).method
> >>> ("getAttributeValue")
> >>>              .with(ANYTHING, ANYTHING)
> >>>              .will(onConsecutiveCalls(returnValue(NAME),
> >>> returnValue (null)));
> >>> @@ -71,7 +71,7 @@
> >>>      }
> >>>
> >>>      public void testInitValue20() throws LoaderException,
> >>> XMLStreamException {
> >>> -        mockReader.expects(once()).method("getName").will
> >>> (returnValue(COMPONENT));
> >>> +        mockReader.expects(atLeastOnce()).method("getName").will
> >>> (returnValue(COMPONENT));
> >>>          mockReader.expects(atLeastOnce()).method
> >>> ("getAttributeValue")
> >>>              .with(ANYTHING, ANYTHING)
> >>>              .will(onConsecutiveCalls(returnValue(NAME),
> >>> returnValue ("20")));
> >>>
> >>>
> >>>
> >>> --------------------------------------------------------------------
> >>> -
> >>> To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
> >>> For additional commands, e-mail: tuscany-commits-help@ws.apache.org
> >>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> >> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>

Re: svn commit: r438000

Posted by Jeremy Boynes <jb...@apache.org>.
One request I would have is to turn off automatic line wrapping in  
Eclipse. Having nicely wrapped at meaningful places (in a checkstyle  
compliwant way), I find it very frustrating that Eclipse rewraps  
those lines based on "first whitespace before the margin" losing my  
changes.

--
Jeremy

On Aug 30, 2006, at 7:54 AM, Jim Marino wrote:

> Then we shuld make sure the two are aligned. I believe other than  
> line length the two are aligned (no pun intended) since the IDEA  
> template works fine for me. The only other mismatch brought up was  
> the idents on cases, which was voted in favor of the current  
> checkstyle. Maybe there are some other mismatches I missed. Could  
> you please highlight them and we can discuss?
>
> Jim
>
> On Aug 30, 2006, at 1:37 AM, ant elder wrote:
>
>> From past discussions there may also be other mismatches and  
>> Raymond said
>> the line length was just one example of a difference. I think the IDE
>> template should be the authority, its the 21st century, we should  
>> be able to
>> use IDE code formatting.
>>
>>   ...ant
>>
>> On 8/30/06, Jim Marino <jm...@myromatours.com> wrote:
>>>
>>> I think it should be the checkstyle. The widest we ever went was 140
>>> and we had a discussion on several occasions where some wanted it
>>> smaller (e.g. 80), some larger, and some didn't care. 120 seems  
>>> to be
>>> a reasonable length. Do you want to update the Eclipse one?
>>>
>>> Jim
>>>
>>> On Aug 29, 2006, at 5:03 PM, Raymond Feng wrote:
>>>
>>> > Hi,
>>> >
>>> > The rules from checkstlye are quite different than the IDE code
>>> > formatter templates we were recommending. For example, the  
>>> template
>>> > for Eclipse sets the maximum characters per line to 150 while the
>>> > checkstyle complains at 120.
>>> >
>>> > Which one should we follow? If it's the checkstyle, then we should
>>> > update the IDE templates so that we are not confused.
>>> >
>>> > Thanks,
>>> > Raymond
>>> >
>>> > ----- Original Message ----- From: "Jim Marino"
>>> > <jm...@myromatours.com>
>>> > To: <tu...@ws.apache.org>
>>> > Sent: Tuesday, August 29, 2006 1:12 AM
>>> > Subject: Fwd: svn commit: r438000
>>> >
>>> >
>>> >> Hi Raymond,
>>> >>
>>> >> Could you please make sure you format this code: mvn -
>>> >> Psourcecheck?  It breaks Checkstyle.
>>> >>
>>> >> Thanks,
>>> >> Jim
>>> >>
>>> >> Begin forwarded message:
>>> >>
>>> >>> From: rfeng@apache.org
>>> >>> Date: August 29, 2006 1:00:16 AM PDT
>>> >>> To: tuscany-commits@ws.apache.org
>>> >>> Subject: svn commit: r438000 - in /incubator/tuscany/java/sca/
>>> >>> core/ src: main/java/org/apache/tuscany/core/loader/
>>> >>> ComponentLoader.java test/java/org/apache/tuscany/core/loader/
>>> >>> ComponentLoaderTestCase.java
>>> >>> Reply-To: tuscany-dev@ws.apache.org
>>> >>>
>>> >>> Author: rfeng
>>> >>> Date: Tue Aug 29 01:00:16 2006
>>> >>> New Revision: 438000
>>> >>>
>>> >>> URL: http://svn.apache.org/viewvc?rev=438000&view=rev
>>> >>> Log:
>>> >>> Make sure the StAX loading only ends upon </component>
>>> >>>
>>> >>> Modified:
>>> >>>     incubator/tuscany/java/sca/core/src/main/java/org/apache/
>>> >>> tuscany/core/loader/ComponentLoader.java
>>> >>>     incubator/tuscany/java/sca/core/src/test/java/org/apache/
>>> >>> tuscany/core/loader/ComponentLoaderTestCase.java
>>> >>>
>>> >>> Modified: incubator/tuscany/java/sca/core/src/main/java/org/
>>> >>> apache/ tuscany/core/loader/ComponentLoader.java
>>> >>> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/
>>> >>> core/ src/main/java/org/apache/tuscany/core/loader/
>>> >>> ComponentLoader.java? rev=438000&r1=437999&r2=438000&view=diff
>>> >>>  
>>> ====================================================================
>>> >>> == ========
>>> >>> --- incubator/tuscany/java/sca/core/src/main/java/org/apache/
>>> >>> tuscany/core/loader/ComponentLoader.java (original)
>>> >>> +++ incubator/tuscany/java/sca/core/src/main/java/org/apache/
>>> >>> tuscany/core/loader/ComponentLoader.java Tue Aug 29 01:00:16  
>>> 2006
>>> >>> @@ -113,7 +113,8 @@
>>> >>>                          reader.next();
>>> >>>                          break;
>>> >>>                      case END_ELEMENT:
>>> >>> -                        return componentDefinition;
>>> >>> +                        if(reader.getName().equals(COMPONENT))
>>> >>> +                            return componentDefinition;
>>> >>>                  }
>>> >>>              }
>>> >>>          } catch (LoaderException e) {
>>> >>>
>>> >>> Modified: incubator/tuscany/java/sca/core/src/test/java/org/
>>> >>> apache/ tuscany/core/loader/ComponentLoaderTestCase.java
>>> >>> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/
>>> >>> core/ src/test/java/org/apache/tuscany/core/loader/
>>> >>> ComponentLoaderTestCase.java?
>>> >>> rev=438000&r1=437999&r2=438000&view=diff
>>> >>>  
>>> ====================================================================
>>> >>> == ========
>>> >>> --- incubator/tuscany/java/sca/core/src/test/java/org/apache/
>>> >>> tuscany/core/loader/ComponentLoaderTestCase.java (original)
>>> >>> +++ incubator/tuscany/java/sca/core/src/test/java/org/apache/
>>> >>> tuscany/core/loader/ComponentLoaderTestCase.java Tue Aug 29
>>> >>> 01:00:16 2006
>>> >>> @@ -57,7 +57,7 @@
>>> >>>      private ComponentLoader loader;
>>> >>>
>>> >>>      public void testEmptyComponent() throws LoaderException,
>>> >>> XMLStreamException {
>>> >>> -        mockReader.expects(once()).method("getName").will
>>> >>> (returnValue(COMPONENT));
>>> >>> +        mockReader.expects(atLeastOnce()).method 
>>> ("getName").will
>>> >>> (returnValue(COMPONENT));
>>> >>>          mockReader.expects(atLeastOnce()).method
>>> >>> ("getAttributeValue")
>>> >>>              .with(ANYTHING, ANYTHING)
>>> >>>              .will(onConsecutiveCalls(returnValue(NAME),
>>> >>> returnValue (null)));
>>> >>> @@ -71,7 +71,7 @@
>>> >>>      }
>>> >>>
>>> >>>      public void testInitValue20() throws LoaderException,
>>> >>> XMLStreamException {
>>> >>> -        mockReader.expects(once()).method("getName").will
>>> >>> (returnValue(COMPONENT));
>>> >>> +        mockReader.expects(atLeastOnce()).method 
>>> ("getName").will
>>> >>> (returnValue(COMPONENT));
>>> >>>          mockReader.expects(atLeastOnce()).method
>>> >>> ("getAttributeValue")
>>> >>>              .with(ANYTHING, ANYTHING)
>>> >>>              .will(onConsecutiveCalls(returnValue(NAME),
>>> >>> returnValue ("20")));
>>> >>>
>>> >>>
>>> >>>
>>> >>>  
>>> --------------------------------------------------------------------
>>> >>> -
>>> >>> To unsubscribe, e-mail: tuscany-commits- 
>>> unsubscribe@ws.apache.org
>>> >>> For additional commands, e-mail: tuscany-commits- 
>>> help@ws.apache.org
>>> >>>
>>> >>
>>> >>
>>> >>  
>>> -------------------------------------------------------------------- 
>>> -
>>> >> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>>> >> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>> >
>>> >
>>> >  
>>> -------------------------------------------------------------------- 
>>> -
>>> > To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>>> > For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>> >
>>>
>>>
>>> -------------------------------------------------------------------- 
>>> -
>>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>>
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


Re: svn commit: r438000

Posted by Jim Marino <jm...@myromatours.com>.
Then we shuld make sure the two are aligned. I believe other than  
line length the two are aligned (no pun intended) since the IDEA  
template works fine for me. The only other mismatch brought up was  
the idents on cases, which was voted in favor of the current  
checkstyle. Maybe there are some other mismatches I missed. Could you  
please highlight them and we can discuss?

Jim

On Aug 30, 2006, at 1:37 AM, ant elder wrote:

> From past discussions there may also be other mismatches and  
> Raymond said
> the line length was just one example of a difference. I think the IDE
> template should be the authority, its the 21st century, we should  
> be able to
> use IDE code formatting.
>
>   ...ant
>
> On 8/30/06, Jim Marino <jm...@myromatours.com> wrote:
>>
>> I think it should be the checkstyle. The widest we ever went was 140
>> and we had a discussion on several occasions where some wanted it
>> smaller (e.g. 80), some larger, and some didn't care. 120 seems to be
>> a reasonable length. Do you want to update the Eclipse one?
>>
>> Jim
>>
>> On Aug 29, 2006, at 5:03 PM, Raymond Feng wrote:
>>
>> > Hi,
>> >
>> > The rules from checkstlye are quite different than the IDE code
>> > formatter templates we were recommending. For example, the template
>> > for Eclipse sets the maximum characters per line to 150 while the
>> > checkstyle complains at 120.
>> >
>> > Which one should we follow? If it's the checkstyle, then we should
>> > update the IDE templates so that we are not confused.
>> >
>> > Thanks,
>> > Raymond
>> >
>> > ----- Original Message ----- From: "Jim Marino"
>> > <jm...@myromatours.com>
>> > To: <tu...@ws.apache.org>
>> > Sent: Tuesday, August 29, 2006 1:12 AM
>> > Subject: Fwd: svn commit: r438000
>> >
>> >
>> >> Hi Raymond,
>> >>
>> >> Could you please make sure you format this code: mvn -
>> >> Psourcecheck?  It breaks Checkstyle.
>> >>
>> >> Thanks,
>> >> Jim
>> >>
>> >> Begin forwarded message:
>> >>
>> >>> From: rfeng@apache.org
>> >>> Date: August 29, 2006 1:00:16 AM PDT
>> >>> To: tuscany-commits@ws.apache.org
>> >>> Subject: svn commit: r438000 - in /incubator/tuscany/java/sca/
>> >>> core/ src: main/java/org/apache/tuscany/core/loader/
>> >>> ComponentLoader.java test/java/org/apache/tuscany/core/loader/
>> >>> ComponentLoaderTestCase.java
>> >>> Reply-To: tuscany-dev@ws.apache.org
>> >>>
>> >>> Author: rfeng
>> >>> Date: Tue Aug 29 01:00:16 2006
>> >>> New Revision: 438000
>> >>>
>> >>> URL: http://svn.apache.org/viewvc?rev=438000&view=rev
>> >>> Log:
>> >>> Make sure the StAX loading only ends upon </component>
>> >>>
>> >>> Modified:
>> >>>     incubator/tuscany/java/sca/core/src/main/java/org/apache/
>> >>> tuscany/core/loader/ComponentLoader.java
>> >>>     incubator/tuscany/java/sca/core/src/test/java/org/apache/
>> >>> tuscany/core/loader/ComponentLoaderTestCase.java
>> >>>
>> >>> Modified: incubator/tuscany/java/sca/core/src/main/java/org/
>> >>> apache/ tuscany/core/loader/ComponentLoader.java
>> >>> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/
>> >>> core/ src/main/java/org/apache/tuscany/core/loader/
>> >>> ComponentLoader.java? rev=438000&r1=437999&r2=438000&view=diff
>> >>>  
>> ====================================================================
>> >>> == ========
>> >>> --- incubator/tuscany/java/sca/core/src/main/java/org/apache/
>> >>> tuscany/core/loader/ComponentLoader.java (original)
>> >>> +++ incubator/tuscany/java/sca/core/src/main/java/org/apache/
>> >>> tuscany/core/loader/ComponentLoader.java Tue Aug 29 01:00:16 2006
>> >>> @@ -113,7 +113,8 @@
>> >>>                          reader.next();
>> >>>                          break;
>> >>>                      case END_ELEMENT:
>> >>> -                        return componentDefinition;
>> >>> +                        if(reader.getName().equals(COMPONENT))
>> >>> +                            return componentDefinition;
>> >>>                  }
>> >>>              }
>> >>>          } catch (LoaderException e) {
>> >>>
>> >>> Modified: incubator/tuscany/java/sca/core/src/test/java/org/
>> >>> apache/ tuscany/core/loader/ComponentLoaderTestCase.java
>> >>> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/
>> >>> core/ src/test/java/org/apache/tuscany/core/loader/
>> >>> ComponentLoaderTestCase.java?
>> >>> rev=438000&r1=437999&r2=438000&view=diff
>> >>>  
>> ====================================================================
>> >>> == ========
>> >>> --- incubator/tuscany/java/sca/core/src/test/java/org/apache/
>> >>> tuscany/core/loader/ComponentLoaderTestCase.java (original)
>> >>> +++ incubator/tuscany/java/sca/core/src/test/java/org/apache/
>> >>> tuscany/core/loader/ComponentLoaderTestCase.java Tue Aug 29
>> >>> 01:00:16 2006
>> >>> @@ -57,7 +57,7 @@
>> >>>      private ComponentLoader loader;
>> >>>
>> >>>      public void testEmptyComponent() throws LoaderException,
>> >>> XMLStreamException {
>> >>> -        mockReader.expects(once()).method("getName").will
>> >>> (returnValue(COMPONENT));
>> >>> +        mockReader.expects(atLeastOnce()).method("getName").will
>> >>> (returnValue(COMPONENT));
>> >>>          mockReader.expects(atLeastOnce()).method
>> >>> ("getAttributeValue")
>> >>>              .with(ANYTHING, ANYTHING)
>> >>>              .will(onConsecutiveCalls(returnValue(NAME),
>> >>> returnValue (null)));
>> >>> @@ -71,7 +71,7 @@
>> >>>      }
>> >>>
>> >>>      public void testInitValue20() throws LoaderException,
>> >>> XMLStreamException {
>> >>> -        mockReader.expects(once()).method("getName").will
>> >>> (returnValue(COMPONENT));
>> >>> +        mockReader.expects(atLeastOnce()).method("getName").will
>> >>> (returnValue(COMPONENT));
>> >>>          mockReader.expects(atLeastOnce()).method
>> >>> ("getAttributeValue")
>> >>>              .with(ANYTHING, ANYTHING)
>> >>>              .will(onConsecutiveCalls(returnValue(NAME),
>> >>> returnValue ("20")));
>> >>>
>> >>>
>> >>>
>> >>>  
>> --------------------------------------------------------------------
>> >>> -
>> >>> To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
>> >>> For additional commands, e-mail: tuscany-commits- 
>> help@ws.apache.org
>> >>>
>> >>
>> >>
>> >>  
>> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>> >> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>> >
>> >
>> >  
>> ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>> > For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


Re: svn commit: r438000

Posted by ant elder <an...@gmail.com>.
>From past discussions there may also be other mismatches and Raymond said
the line length was just one example of a difference. I think the IDE
template should be the authority, its the 21st century, we should be able to
use IDE code formatting.

   ...ant

On 8/30/06, Jim Marino <jm...@myromatours.com> wrote:
>
> I think it should be the checkstyle. The widest we ever went was 140
> and we had a discussion on several occasions where some wanted it
> smaller (e.g. 80), some larger, and some didn't care. 120 seems to be
> a reasonable length. Do you want to update the Eclipse one?
>
> Jim
>
> On Aug 29, 2006, at 5:03 PM, Raymond Feng wrote:
>
> > Hi,
> >
> > The rules from checkstlye are quite different than the IDE code
> > formatter templates we were recommending. For example, the template
> > for Eclipse sets the maximum characters per line to 150 while the
> > checkstyle complains at 120.
> >
> > Which one should we follow? If it's the checkstyle, then we should
> > update the IDE templates so that we are not confused.
> >
> > Thanks,
> > Raymond
> >
> > ----- Original Message ----- From: "Jim Marino"
> > <jm...@myromatours.com>
> > To: <tu...@ws.apache.org>
> > Sent: Tuesday, August 29, 2006 1:12 AM
> > Subject: Fwd: svn commit: r438000
> >
> >
> >> Hi Raymond,
> >>
> >> Could you please make sure you format this code: mvn -
> >> Psourcecheck?  It breaks Checkstyle.
> >>
> >> Thanks,
> >> Jim
> >>
> >> Begin forwarded message:
> >>
> >>> From: rfeng@apache.org
> >>> Date: August 29, 2006 1:00:16 AM PDT
> >>> To: tuscany-commits@ws.apache.org
> >>> Subject: svn commit: r438000 - in /incubator/tuscany/java/sca/
> >>> core/ src: main/java/org/apache/tuscany/core/loader/
> >>> ComponentLoader.java test/java/org/apache/tuscany/core/loader/
> >>> ComponentLoaderTestCase.java
> >>> Reply-To: tuscany-dev@ws.apache.org
> >>>
> >>> Author: rfeng
> >>> Date: Tue Aug 29 01:00:16 2006
> >>> New Revision: 438000
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=438000&view=rev
> >>> Log:
> >>> Make sure the StAX loading only ends upon </component>
> >>>
> >>> Modified:
> >>>     incubator/tuscany/java/sca/core/src/main/java/org/apache/
> >>> tuscany/core/loader/ComponentLoader.java
> >>>     incubator/tuscany/java/sca/core/src/test/java/org/apache/
> >>> tuscany/core/loader/ComponentLoaderTestCase.java
> >>>
> >>> Modified: incubator/tuscany/java/sca/core/src/main/java/org/
> >>> apache/ tuscany/core/loader/ComponentLoader.java
> >>> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/
> >>> core/ src/main/java/org/apache/tuscany/core/loader/
> >>> ComponentLoader.java? rev=438000&r1=437999&r2=438000&view=diff
> >>> ====================================================================
> >>> == ========
> >>> --- incubator/tuscany/java/sca/core/src/main/java/org/apache/
> >>> tuscany/core/loader/ComponentLoader.java (original)
> >>> +++ incubator/tuscany/java/sca/core/src/main/java/org/apache/
> >>> tuscany/core/loader/ComponentLoader.java Tue Aug 29 01:00:16 2006
> >>> @@ -113,7 +113,8 @@
> >>>                          reader.next();
> >>>                          break;
> >>>                      case END_ELEMENT:
> >>> -                        return componentDefinition;
> >>> +                        if(reader.getName().equals(COMPONENT))
> >>> +                            return componentDefinition;
> >>>                  }
> >>>              }
> >>>          } catch (LoaderException e) {
> >>>
> >>> Modified: incubator/tuscany/java/sca/core/src/test/java/org/
> >>> apache/ tuscany/core/loader/ComponentLoaderTestCase.java
> >>> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/
> >>> core/ src/test/java/org/apache/tuscany/core/loader/
> >>> ComponentLoaderTestCase.java?
> >>> rev=438000&r1=437999&r2=438000&view=diff
> >>> ====================================================================
> >>> == ========
> >>> --- incubator/tuscany/java/sca/core/src/test/java/org/apache/
> >>> tuscany/core/loader/ComponentLoaderTestCase.java (original)
> >>> +++ incubator/tuscany/java/sca/core/src/test/java/org/apache/
> >>> tuscany/core/loader/ComponentLoaderTestCase.java Tue Aug 29
> >>> 01:00:16 2006
> >>> @@ -57,7 +57,7 @@
> >>>      private ComponentLoader loader;
> >>>
> >>>      public void testEmptyComponent() throws LoaderException,
> >>> XMLStreamException {
> >>> -        mockReader.expects(once()).method("getName").will
> >>> (returnValue(COMPONENT));
> >>> +        mockReader.expects(atLeastOnce()).method("getName").will
> >>> (returnValue(COMPONENT));
> >>>          mockReader.expects(atLeastOnce()).method
> >>> ("getAttributeValue")
> >>>              .with(ANYTHING, ANYTHING)
> >>>              .will(onConsecutiveCalls(returnValue(NAME),
> >>> returnValue (null)));
> >>> @@ -71,7 +71,7 @@
> >>>      }
> >>>
> >>>      public void testInitValue20() throws LoaderException,
> >>> XMLStreamException {
> >>> -        mockReader.expects(once()).method("getName").will
> >>> (returnValue(COMPONENT));
> >>> +        mockReader.expects(atLeastOnce()).method("getName").will
> >>> (returnValue(COMPONENT));
> >>>          mockReader.expects(atLeastOnce()).method
> >>> ("getAttributeValue")
> >>>              .with(ANYTHING, ANYTHING)
> >>>              .will(onConsecutiveCalls(returnValue(NAME),
> >>> returnValue ("20")));
> >>>
> >>>
> >>>
> >>> --------------------------------------------------------------------
> >>> -
> >>> To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
> >>> For additional commands, e-mail: tuscany-commits-help@ws.apache.org
> >>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> >> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>

Re: svn commit: r438000

Posted by Jim Marino <jm...@myromatours.com>.
I think it should be the checkstyle. The widest we ever went was 140  
and we had a discussion on several occasions where some wanted it  
smaller (e.g. 80), some larger, and some didn't care. 120 seems to be  
a reasonable length. Do you want to update the Eclipse one?

Jim

On Aug 29, 2006, at 5:03 PM, Raymond Feng wrote:

> Hi,
>
> The rules from checkstlye are quite different than the IDE code  
> formatter templates we were recommending. For example, the template  
> for Eclipse sets the maximum characters per line to 150 while the  
> checkstyle complains at 120.
>
> Which one should we follow? If it's the checkstyle, then we should  
> update the IDE templates so that we are not confused.
>
> Thanks,
> Raymond
>
> ----- Original Message ----- From: "Jim Marino"  
> <jm...@myromatours.com>
> To: <tu...@ws.apache.org>
> Sent: Tuesday, August 29, 2006 1:12 AM
> Subject: Fwd: svn commit: r438000
>
>
>> Hi Raymond,
>>
>> Could you please make sure you format this code: mvn - 
>> Psourcecheck?  It breaks Checkstyle.
>>
>> Thanks,
>> Jim
>>
>> Begin forwarded message:
>>
>>> From: rfeng@apache.org
>>> Date: August 29, 2006 1:00:16 AM PDT
>>> To: tuscany-commits@ws.apache.org
>>> Subject: svn commit: r438000 - in /incubator/tuscany/java/sca/ 
>>> core/ src: main/java/org/apache/tuscany/core/loader/ 
>>> ComponentLoader.java test/java/org/apache/tuscany/core/loader/ 
>>> ComponentLoaderTestCase.java
>>> Reply-To: tuscany-dev@ws.apache.org
>>>
>>> Author: rfeng
>>> Date: Tue Aug 29 01:00:16 2006
>>> New Revision: 438000
>>>
>>> URL: http://svn.apache.org/viewvc?rev=438000&view=rev
>>> Log:
>>> Make sure the StAX loading only ends upon </component>
>>>
>>> Modified:
>>>     incubator/tuscany/java/sca/core/src/main/java/org/apache/  
>>> tuscany/core/loader/ComponentLoader.java
>>>     incubator/tuscany/java/sca/core/src/test/java/org/apache/  
>>> tuscany/core/loader/ComponentLoaderTestCase.java
>>>
>>> Modified: incubator/tuscany/java/sca/core/src/main/java/org/ 
>>> apache/ tuscany/core/loader/ComponentLoader.java
>>> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/ 
>>> core/ src/main/java/org/apache/tuscany/core/loader/ 
>>> ComponentLoader.java? rev=438000&r1=437999&r2=438000&view=diff
>>> ==================================================================== 
>>> == ========
>>> --- incubator/tuscany/java/sca/core/src/main/java/org/apache/  
>>> tuscany/core/loader/ComponentLoader.java (original)
>>> +++ incubator/tuscany/java/sca/core/src/main/java/org/apache/  
>>> tuscany/core/loader/ComponentLoader.java Tue Aug 29 01:00:16 2006
>>> @@ -113,7 +113,8 @@
>>>                          reader.next();
>>>                          break;
>>>                      case END_ELEMENT:
>>> -                        return componentDefinition;
>>> +                        if(reader.getName().equals(COMPONENT))
>>> +                            return componentDefinition;
>>>                  }
>>>              }
>>>          } catch (LoaderException e) {
>>>
>>> Modified: incubator/tuscany/java/sca/core/src/test/java/org/ 
>>> apache/ tuscany/core/loader/ComponentLoaderTestCase.java
>>> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/ 
>>> core/ src/test/java/org/apache/tuscany/core/loader/  
>>> ComponentLoaderTestCase.java? 
>>> rev=438000&r1=437999&r2=438000&view=diff
>>> ==================================================================== 
>>> == ========
>>> --- incubator/tuscany/java/sca/core/src/test/java/org/apache/  
>>> tuscany/core/loader/ComponentLoaderTestCase.java (original)
>>> +++ incubator/tuscany/java/sca/core/src/test/java/org/apache/  
>>> tuscany/core/loader/ComponentLoaderTestCase.java Tue Aug 29   
>>> 01:00:16 2006
>>> @@ -57,7 +57,7 @@
>>>      private ComponentLoader loader;
>>>
>>>      public void testEmptyComponent() throws LoaderException,  
>>> XMLStreamException {
>>> -        mockReader.expects(once()).method("getName").will  
>>> (returnValue(COMPONENT));
>>> +        mockReader.expects(atLeastOnce()).method("getName").will  
>>> (returnValue(COMPONENT));
>>>          mockReader.expects(atLeastOnce()).method 
>>> ("getAttributeValue")
>>>              .with(ANYTHING, ANYTHING)
>>>              .will(onConsecutiveCalls(returnValue(NAME),  
>>> returnValue (null)));
>>> @@ -71,7 +71,7 @@
>>>      }
>>>
>>>      public void testInitValue20() throws LoaderException,  
>>> XMLStreamException {
>>> -        mockReader.expects(once()).method("getName").will  
>>> (returnValue(COMPONENT));
>>> +        mockReader.expects(atLeastOnce()).method("getName").will  
>>> (returnValue(COMPONENT));
>>>          mockReader.expects(atLeastOnce()).method 
>>> ("getAttributeValue")
>>>              .with(ANYTHING, ANYTHING)
>>>              .will(onConsecutiveCalls(returnValue(NAME),  
>>> returnValue ("20")));
>>>
>>>
>>>
>>> -------------------------------------------------------------------- 
>>> -
>>> To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
>>> For additional commands, e-mail: tuscany-commits-help@ws.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


Re: svn commit: r438000

Posted by Raymond Feng <en...@gmail.com>.
Hi,

The rules from checkstlye are quite different than the IDE code formatter 
templates we were recommending. For example, the template for Eclipse sets 
the maximum characters per line to 150 while the checkstyle complains at 
120.

Which one should we follow? If it's the checkstyle, then we should update 
the IDE templates so that we are not confused.

Thanks,
Raymond

----- Original Message ----- 
From: "Jim Marino" <jm...@myromatours.com>
To: <tu...@ws.apache.org>
Sent: Tuesday, August 29, 2006 1:12 AM
Subject: Fwd: svn commit: r438000


> Hi Raymond,
>
> Could you please make sure you format this code: mvn -Psourcecheck?  It 
> breaks Checkstyle.
>
> Thanks,
> Jim
>
> Begin forwarded message:
>
>> From: rfeng@apache.org
>> Date: August 29, 2006 1:00:16 AM PDT
>> To: tuscany-commits@ws.apache.org
>> Subject: svn commit: r438000 - in /incubator/tuscany/java/sca/core/ src: 
>> main/java/org/apache/tuscany/core/loader/ComponentLoader.java 
>> test/java/org/apache/tuscany/core/loader/ComponentLoaderTestCase.java
>> Reply-To: tuscany-dev@ws.apache.org
>>
>> Author: rfeng
>> Date: Tue Aug 29 01:00:16 2006
>> New Revision: 438000
>>
>> URL: http://svn.apache.org/viewvc?rev=438000&view=rev
>> Log:
>> Make sure the StAX loading only ends upon </component>
>>
>> Modified:
>>     incubator/tuscany/java/sca/core/src/main/java/org/apache/ 
>> tuscany/core/loader/ComponentLoader.java
>>     incubator/tuscany/java/sca/core/src/test/java/org/apache/ 
>> tuscany/core/loader/ComponentLoaderTestCase.java
>>
>> Modified: incubator/tuscany/java/sca/core/src/main/java/org/apache/ 
>> tuscany/core/loader/ComponentLoader.java
>> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/core/ 
>> src/main/java/org/apache/tuscany/core/loader/ComponentLoader.java? 
>> rev=438000&r1=437999&r2=438000&view=diff
>> ====================================================================== 
>> ========
>> --- incubator/tuscany/java/sca/core/src/main/java/org/apache/ 
>> tuscany/core/loader/ComponentLoader.java (original)
>> +++ incubator/tuscany/java/sca/core/src/main/java/org/apache/ 
>> tuscany/core/loader/ComponentLoader.java Tue Aug 29 01:00:16 2006
>> @@ -113,7 +113,8 @@
>>                          reader.next();
>>                          break;
>>                      case END_ELEMENT:
>> -                        return componentDefinition;
>> +                        if(reader.getName().equals(COMPONENT))
>> +                            return componentDefinition;
>>                  }
>>              }
>>          } catch (LoaderException e) {
>>
>> Modified: incubator/tuscany/java/sca/core/src/test/java/org/apache/ 
>> tuscany/core/loader/ComponentLoaderTestCase.java
>> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/core/ 
>> src/test/java/org/apache/tuscany/core/loader/ 
>> ComponentLoaderTestCase.java?rev=438000&r1=437999&r2=438000&view=diff
>> ====================================================================== 
>> ========
>> --- incubator/tuscany/java/sca/core/src/test/java/org/apache/ 
>> tuscany/core/loader/ComponentLoaderTestCase.java (original)
>> +++ incubator/tuscany/java/sca/core/src/test/java/org/apache/ 
>> tuscany/core/loader/ComponentLoaderTestCase.java Tue Aug 29  01:00:16 
>> 2006
>> @@ -57,7 +57,7 @@
>>      private ComponentLoader loader;
>>
>>      public void testEmptyComponent() throws LoaderException, 
>> XMLStreamException {
>> -        mockReader.expects(once()).method("getName").will 
>> (returnValue(COMPONENT));
>> +        mockReader.expects(atLeastOnce()).method("getName").will 
>> (returnValue(COMPONENT));
>>          mockReader.expects(atLeastOnce()).method("getAttributeValue")
>>              .with(ANYTHING, ANYTHING)
>>              .will(onConsecutiveCalls(returnValue(NAME), returnValue 
>> (null)));
>> @@ -71,7 +71,7 @@
>>      }
>>
>>      public void testInitValue20() throws LoaderException, 
>> XMLStreamException {
>> -        mockReader.expects(once()).method("getName").will 
>> (returnValue(COMPONENT));
>> +        mockReader.expects(atLeastOnce()).method("getName").will 
>> (returnValue(COMPONENT));
>>          mockReader.expects(atLeastOnce()).method("getAttributeValue")
>>              .with(ANYTHING, ANYTHING)
>>              .will(onConsecutiveCalls(returnValue(NAME), returnValue 
>> ("20")));
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
>> For additional commands, e-mail: tuscany-commits-help@ws.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


Fwd: svn commit: r438000

Posted by Jim Marino <jm...@myromatours.com>.
Hi Raymond,

Could you please make sure you format this code: mvn -Psourcecheck?  
It breaks Checkstyle.

Thanks,
Jim

Begin forwarded message:

> From: rfeng@apache.org
> Date: August 29, 2006 1:00:16 AM PDT
> To: tuscany-commits@ws.apache.org
> Subject: svn commit: r438000 - in /incubator/tuscany/java/sca/core/ 
> src: main/java/org/apache/tuscany/core/loader/ComponentLoader.java  
> test/java/org/apache/tuscany/core/loader/ComponentLoaderTestCase.java
> Reply-To: tuscany-dev@ws.apache.org
>
> Author: rfeng
> Date: Tue Aug 29 01:00:16 2006
> New Revision: 438000
>
> URL: http://svn.apache.org/viewvc?rev=438000&view=rev
> Log:
> Make sure the StAX loading only ends upon </component>
>
> Modified:
>     incubator/tuscany/java/sca/core/src/main/java/org/apache/ 
> tuscany/core/loader/ComponentLoader.java
>     incubator/tuscany/java/sca/core/src/test/java/org/apache/ 
> tuscany/core/loader/ComponentLoaderTestCase.java
>
> Modified: incubator/tuscany/java/sca/core/src/main/java/org/apache/ 
> tuscany/core/loader/ComponentLoader.java
> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/core/ 
> src/main/java/org/apache/tuscany/core/loader/ComponentLoader.java? 
> rev=438000&r1=437999&r2=438000&view=diff
> ====================================================================== 
> ========
> --- incubator/tuscany/java/sca/core/src/main/java/org/apache/ 
> tuscany/core/loader/ComponentLoader.java (original)
> +++ incubator/tuscany/java/sca/core/src/main/java/org/apache/ 
> tuscany/core/loader/ComponentLoader.java Tue Aug 29 01:00:16 2006
> @@ -113,7 +113,8 @@
>                          reader.next();
>                          break;
>                      case END_ELEMENT:
> -                        return componentDefinition;
> +                        if(reader.getName().equals(COMPONENT))
> +                            return componentDefinition;
>                  }
>              }
>          } catch (LoaderException e) {
>
> Modified: incubator/tuscany/java/sca/core/src/test/java/org/apache/ 
> tuscany/core/loader/ComponentLoaderTestCase.java
> URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/core/ 
> src/test/java/org/apache/tuscany/core/loader/ 
> ComponentLoaderTestCase.java?rev=438000&r1=437999&r2=438000&view=diff
> ====================================================================== 
> ========
> --- incubator/tuscany/java/sca/core/src/test/java/org/apache/ 
> tuscany/core/loader/ComponentLoaderTestCase.java (original)
> +++ incubator/tuscany/java/sca/core/src/test/java/org/apache/ 
> tuscany/core/loader/ComponentLoaderTestCase.java Tue Aug 29  
> 01:00:16 2006
> @@ -57,7 +57,7 @@
>      private ComponentLoader loader;
>
>      public void testEmptyComponent() throws LoaderException,  
> XMLStreamException {
> -        mockReader.expects(once()).method("getName").will 
> (returnValue(COMPONENT));
> +        mockReader.expects(atLeastOnce()).method("getName").will 
> (returnValue(COMPONENT));
>          mockReader.expects(atLeastOnce()).method("getAttributeValue")
>              .with(ANYTHING, ANYTHING)
>              .will(onConsecutiveCalls(returnValue(NAME), returnValue 
> (null)));
> @@ -71,7 +71,7 @@
>      }
>
>      public void testInitValue20() throws LoaderException,  
> XMLStreamException {
> -        mockReader.expects(once()).method("getName").will 
> (returnValue(COMPONENT));
> +        mockReader.expects(atLeastOnce()).method("getName").will 
> (returnValue(COMPONENT));
>          mockReader.expects(atLeastOnce()).method("getAttributeValue")
>              .with(ANYTHING, ANYTHING)
>              .will(onConsecutiveCalls(returnValue(NAME), returnValue 
> ("20")));
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-commits-help@ws.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org