You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2016/02/22 02:43:34 UTC

Review Request 43813: SENTRY-1090: Improvement for CommonPrivilege

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43813/
-----------------------------------------------------------

Review request for sentry and Hao Hao.


Repository: sentry


Description
-------

The following will be improved in CommonPrivilege:
1. Add wildcard support when compare the resource as string.
2. Add more comments.


Diffs
-----

  sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java af3a7dd 
  sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/PolicyConstants.java 8e4d465 

Diff: https://reviews.apache.org/r/43813/diff/


Testing
-------


Thanks,

Colin Ma

Re: Review Request 43813: SENTRY-1090: Improvement for CommonPrivilege

Posted by Hao Hao <ha...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43813/#review120101
-----------------------------------------------------------


Ship it!




Ship It!

- Hao Hao


On Feb. 22, 2016, 1:43 a.m., Colin Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43813/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 1:43 a.m.)
> 
> 
> Review request for sentry and Hao Hao.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> The following will be improved in CommonPrivilege:
> 1. Add wildcard support when compare the resource as string.
> 2. Add more comments.
> 
> 
> Diffs
> -----
> 
>   sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java af3a7dd 
>   sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/PolicyConstants.java 8e4d465 
> 
> Diff: https://reviews.apache.org/r/43813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Ma
> 
>