You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by "rovarga (via GitHub)" <gi...@apache.org> on 2023/10/02 00:44:54 UTC
[GitHub] [karaf] rovarga opened a new pull request, #1784: [KARAF-7768]: Provide SPI Fly from framework
rovarga opened a new pull request, #1784:
URL: https://github.com/apache/karaf/pull/1784
Signed-off-by: Robert Varga <ro...@pantheon.tech>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KARAF-7768]: Provide SPI Fly from framework [karaf]
Posted by "rovarga (via GitHub)" <gi...@apache.org>.
rovarga commented on code in PR #1784:
URL: https://github.com/apache/karaf/pull/1784#discussion_r1451604246
##########
assemblies/features/framework/src/main/feature/feature.xml:
##########
@@ -45,6 +45,20 @@
<bundle start-level="12">mvn:org.apache.felix/org.apache.felix.fileinstall/${felix.fileinstall.version}</bundle>
<!-- features service -->
<bundle start-level="15">mvn:org.apache.karaf.features/org.apache.karaf.features.core/${project.version}</bundle>
+
+ <!--
+ ASM/SPI Fly integration.
+
+ spifly.dynamic.bundle and not spifly.dynamic.framework.extension, in order to lower ASM library duplication: other projects
+ are using them. A more packaging-intensive operation would be to package these 6 bundles as 1-2 framework extensions.
+ -->
+ <bundle dependency="false" start-level="20">mvn:org.ow2.asm/asm/${asm.version}</bundle>
Review Comment:
Yeah, that got me thinking as well, simply because at that point we really are guided towards spifly.dynamic.framework.extension, which is a heavyweight.
Having thought about this quite a bit a more, I believe want to do something else here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KARAF-7768]: Provide SPI Fly from framework [karaf]
Posted by "rovarga (via GitHub)" <gi...@apache.org>.
rovarga commented on PR #1784:
URL: https://github.com/apache/karaf/pull/1784#issuecomment-1890765848
This PR does the wrong thing, I will raise another one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KARAF-7768]: Provide SPI Fly from framework [karaf]
Posted by "rovarga (via GitHub)" <gi...@apache.org>.
rovarga closed pull request #1784: [KARAF-7768]: Provide SPI Fly from framework
URL: https://github.com/apache/karaf/pull/1784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KARAF-7768]: Provide SPI Fly from framework [karaf]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1784:
URL: https://github.com/apache/karaf/pull/1784#discussion_r1397331349
##########
assemblies/features/framework/src/main/feature/feature.xml:
##########
@@ -45,6 +45,20 @@
<bundle start-level="12">mvn:org.apache.felix/org.apache.felix.fileinstall/${felix.fileinstall.version}</bundle>
<!-- features service -->
<bundle start-level="15">mvn:org.apache.karaf.features/org.apache.karaf.features.core/${project.version}</bundle>
+
+ <!--
+ ASM/SPI Fly integration.
+
+ spifly.dynamic.bundle and not spifly.dynamic.framework.extension, in order to lower ASM library duplication: other projects
+ are using them. A more packaging-intensive operation would be to package these 6 bundles as 1-2 framework extensions.
+ -->
+ <bundle dependency="false" start-level="20">mvn:org.ow2.asm/asm/${asm.version}</bundle>
Review Comment:
do we really think it's a good idea to provide spifly at framework level ? Just thinking :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org