You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/07 22:57:38 UTC

[GitHub] [airflow] vchiapaikeo commented on a diff in pull request #28781: Fix UIAlert should_show when AUTH_ROLE_PUBLIC set

vchiapaikeo commented on code in PR #28781:
URL: https://github.com/apache/airflow/pull/28781#discussion_r1064056434


##########
airflow/www/utils.py:
##########
@@ -821,9 +821,24 @@ def __init__(
         self.message = Markup(message) if html else message
 
     def should_show(self, securitymanager) -> bool:
-        """Determine if the user should see the message based on their role membership"""
+        """

Review Comment:
   Do you think I should type it with SecurityManager or BaseSecurityManager? I did the former but please let me know if we should do the latter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org