You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Pierre-Arnaud Marcelot <pa...@marcelot.net> on 2008/02/06 11:56:35 UTC

Re: svn commit: r618957 - /directory/studio/branches/studio-maven/updatesite/pom.xml

Felix,

Is this 'current_pom_version' variable still used ?

Thanks,
Pierre-Arnaud

On Feb 6, 2008 11:55 AM, <pa...@apache.org> wrote:

> Author: pamarcelot
> Date: Wed Feb  6 02:55:22 2008
> New Revision: 618957
>
> URL: http://svn.apache.org/viewvc?rev=618957&view=rev
> Log:
> Removed comment.
>
> Modified:
>    directory/studio/branches/studio-maven/updatesite/pom.xml
>
> Modified: directory/studio/branches/studio-maven/updatesite/pom.xml
> URL:
> http://svn.apache.org/viewvc/directory/studio/branches/studio-maven/updatesite/pom.xml?rev=618957&r1=618956&r2=618957&view=diff
>
> ==============================================================================
> --- directory/studio/branches/studio-maven/updatesite/pom.xml (original)
> +++ directory/studio/branches/studio-maven/updatesite/pom.xml Wed Feb  6
> 02:55:22 2008
> @@ -34,7 +34,6 @@
>
>   <description></description>
>
> -  <!-- Set path for local repository and others-->
>   <properties>
>     <current_pom_version>${pom.version}</current_pom_version>
>   </properties>
>
>
>

Re: svn commit: r618957 - /directory/studio/branches/studio-maven/updatesite/pom.xml

Posted by Felix Knecht <fe...@apache.org>.
Pierre-Arnaud Marcelot schrieb:
> This would be very great!
> No more hand-editing when releasing... :)

I'll do

Felix
>
> Pierre-Arnaud
>
> On Feb 6, 2008 12:22 PM, Felix Knecht <felixk@apache.org 
> <ma...@apache.org>> wrote:
>
>     Pierre-Arnaud Marcelot schrieb:
>     > Are you sure?
>     > I can't find any mention to "current_pom_version" in the
>     site.xml file...
>
>     S*** I looked in my sandbox. Thanks for hinting. Looking at the real
>     site*.* I can see that you replaced it with hardcoded versions of the
>     plugins. We could use also property replacement here as we do have the
>     versions from properties in the root pom.
>
>     Filtering the site*.* should work and is configured this way when
>     building the updatesite module.
>
>     Felix
>
>


Re: svn commit: r618957 - /directory/studio/branches/studio-maven/updatesite/pom.xml

Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
This would be very great!
No more hand-editing when releasing... :)

Pierre-Arnaud

On Feb 6, 2008 12:22 PM, Felix Knecht <fe...@apache.org> wrote:

> Pierre-Arnaud Marcelot schrieb:
> > Are you sure?
> > I can't find any mention to "current_pom_version" in the site.xmlfile...
>
> S*** I looked in my sandbox. Thanks for hinting. Looking at the real
> site*.* I can see that you replaced it with hardcoded versions of the
> plugins. We could use also property replacement here as we do have the
> versions from properties in the root pom.
>
> Filtering the site*.* should work and is configured this way when
> building the updatesite module.
>
> Felix
>
>

Re: svn commit: r618957 - /directory/studio/branches/studio-maven/updatesite/pom.xml

Posted by Felix Knecht <fe...@apache.org>.
Pierre-Arnaud Marcelot schrieb:
> Are you sure?
> I can't find any mention to "current_pom_version" in the site.xml file...

S*** I looked in my sandbox. Thanks for hinting. Looking at the real 
site*.* I can see that you replaced it with hardcoded versions of the 
plugins. We could use also property replacement here as we do have the 
versions from properties in the root pom.

Filtering the site*.* should work and is configured this way when 
building the updatesite module.

Felix


Re: svn commit: r618957 - /directory/studio/branches/studio-maven/updatesite/pom.xml

Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
Are you sure?
I can't find any mention to "current_pom_version" in the site.xml file...

Pierre-Arnaud

On Feb 6, 2008 12:04 PM, Felix Knecht <fe...@apache.org> wrote:

> Pierre-Arnaud Marcelot schrieb:
> > Felix,
> >
> > Is this 'current_pom_version' variable still used ?
>
> In principle not. But your question pointed me to another point we need
> to fix: ATM current_pom_version is used in the
> updatesite/src/main/resources/site.xml to generate to url attribute in
> the feature tags what is wrong nowadays because different features can
> have different versions. I'm going to remove/fix this.
>
> Regards
> Felix
>
> >
> > Thanks,
> > Pierre-Arnaud
> >
> > On Feb 6, 2008 11:55 AM, <pamarcelot@apache.org
> > <ma...@apache.org>> wrote:
> >
> >     Author: pamarcelot
> >     Date: Wed Feb  6 02:55:22 2008
> >     New Revision: 618957
> >
> >     URL: http://svn.apache.org/viewvc?rev=618957&view=rev
> >     <http://svn.apache.org/viewvc?rev=618957&view=rev>
> >     Log:
> >     Removed comment.
> >
> >     Modified:
> >        directory/studio/branches/studio-maven/updatesite/pom.xml
> >
> >     Modified: directory/studio/branches/studio-maven/updatesite/pom.xml
> >     URL:
> >
> http://svn.apache.org/viewvc/directory/studio/branches/studio-maven/updatesite/pom.xml?rev=618957&r1=618956&r2=618957&view=diff
> >     <
> http://svn.apache.org/viewvc/directory/studio/branches/studio-maven/updatesite/pom.xml?rev=618957&r1=618956&r2=618957&view=diff
> >
> >
> ==============================================================================
> >     --- directory/studio/branches/studio-maven/updatesite/pom.xml
> >     (original)
> >     +++ directory/studio/branches/studio-maven/updatesite/pom.xml Wed
> >     Feb  6 02:55:22 2008
> >     @@ -34,7 +34,6 @@
> >
> >       <description></description>
> >
> >     -  <!-- Set path for local repository and others-->
> >       <properties>
> >         <current_pom_version>${pom.version}</current_pom_version>
> >       </properties>
> >
> >
> >
>
>

Re: svn commit: r618957 - /directory/studio/branches/studio-maven/updatesite/pom.xml

Posted by Felix Knecht <fe...@apache.org>.
Pierre-Arnaud Marcelot schrieb:
> Felix,
>
> Is this 'current_pom_version' variable still used ?

In principle not. But your question pointed me to another point we need 
to fix: ATM current_pom_version is used in the 
updatesite/src/main/resources/site.xml to generate to url attribute in 
the feature tags what is wrong nowadays because different features can 
have different versions. I'm going to remove/fix this.

Regards
Felix

>
> Thanks,
> Pierre-Arnaud
>
> On Feb 6, 2008 11:55 AM, <pamarcelot@apache.org 
> <ma...@apache.org>> wrote:
>
>     Author: pamarcelot
>     Date: Wed Feb  6 02:55:22 2008
>     New Revision: 618957
>
>     URL: http://svn.apache.org/viewvc?rev=618957&view=rev
>     <http://svn.apache.org/viewvc?rev=618957&view=rev>
>     Log:
>     Removed comment.
>
>     Modified:
>        directory/studio/branches/studio-maven/updatesite/pom.xml
>
>     Modified: directory/studio/branches/studio-maven/updatesite/pom.xml
>     URL:
>     http://svn.apache.org/viewvc/directory/studio/branches/studio-maven/updatesite/pom.xml?rev=618957&r1=618956&r2=618957&view=diff
>     <http://svn.apache.org/viewvc/directory/studio/branches/studio-maven/updatesite/pom.xml?rev=618957&r1=618956&r2=618957&view=diff>
>     ==============================================================================
>     --- directory/studio/branches/studio-maven/updatesite/pom.xml
>     (original)
>     +++ directory/studio/branches/studio-maven/updatesite/pom.xml Wed
>     Feb  6 02:55:22 2008
>     @@ -34,7 +34,6 @@
>
>       <description></description>
>
>     -  <!-- Set path for local repository and others-->
>       <properties>
>         <current_pom_version>${pom.version}</current_pom_version>
>       </properties>
>
>
>