You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/07 19:25:27 UTC
[GitHub] [airflow] lostkamp opened a new pull request, #24905: Fix pod override precedence
lostkamp opened a new pull request, #24905:
URL: https://github.com/apache/airflow/pull/24905
Follow-up to #24342
Closes #22298
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lostkamp commented on pull request #24905: Fix pod override precedence
Posted by GitBox <gi...@apache.org>.
lostkamp commented on PR #24905:
URL: https://github.com/apache/airflow/pull/24905#issuecomment-1178120265
@potiuk here the re-opened MR with the same changes as the old one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #24905: KubernetesExecutor: Use user-provided namespace from executor_config arg
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #24905: KubernetesExecutor: Use user-provided namespace from executor_config arg
URL: https://github.com/apache/airflow/pull/24905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24905: KubernetesExecutor: Use user-provided namespace from executor_config arg
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24905:
URL: https://github.com/apache/airflow/pull/24905#issuecomment-1237539359
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24905: KubernetesExecutor: Use user-provided namespace from executor_config arg
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24905:
URL: https://github.com/apache/airflow/pull/24905#issuecomment-1183508084
Now - it nicely failed in K8S tests :). so the selective checks worked. The tests need to be fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lostkamp commented on pull request #24905: KubernetesExecutor: Use user-provided namespace from executor_config arg
Posted by GitBox <gi...@apache.org>.
lostkamp commented on PR #24905:
URL: https://github.com/apache/airflow/pull/24905#issuecomment-1189447096
Okay, so from what I understand, the tests `test_integration_run_dag` and `test_integration_run_dag_with_scheduler_failure` in kubernetes_tests/test_kubernetes_executor.py are failing because they are timing out. Sorry, but I don't understand how this is related to the changes in this PR. I would need some help to fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lostkamp commented on pull request #24905: KubernetesExecutor: Use user-provided namespace from executor_config arg
Posted by GitBox <gi...@apache.org>.
lostkamp commented on PR #24905:
URL: https://github.com/apache/airflow/pull/24905#issuecomment-1192326311
thanks for the hint. however, I still don't fully understand what is going on:
the first failing test is monitoring `start_task`, but that task only adds an annotation via pod_override, there is no namespace change. the second failing test does chang the namespace in `other_namespace_task`. But if the namespace does not exist, I would expect an error and not a final state of "running". Also when I search for "test-namespace" in the job logs, I see a `kubectl create namespace test-namespace` command.
Sorry, but I don't think I'm able to debug this by myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #24905: KubernetesExecutor: Use user-provided namespace from executor_config arg
Posted by GitBox <gi...@apache.org>.
dstandish commented on PR #24905:
URL: https://github.com/apache/airflow/pull/24905#issuecomment-1189460840
@lostkamp that test is running dag `example_kubernetes_executor`. take a look there. it is passing namespace to executor config. maybe the namespace does not exist so the task never starts, so it times out? something to look into.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24905: KubernetesExecutor: Use user-provided namespace from executor_config arg
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24905:
URL: https://github.com/apache/airflow/pull/24905#issuecomment-1179771702
OK. I improved the selective checks to also trigger Helm tests when airflow/kubernetes files get changed.
https://github.com/apache/airflow/pull/24950
I will ask you to rebase after I merge it so that you will be able to see and fix the test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org