You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/02 17:11:43 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #1632: Fix UnionArray is_null

viirya commented on code in PR #1632:
URL: https://github.com/apache/arrow-rs/pull/1632#discussion_r863025398


##########
arrow/src/array/array_union.rs:
##########
@@ -304,6 +304,24 @@ impl Array for UnionArray {
     fn data(&self) -> &ArrayData {
         &self.data
     }
+

Review Comment:
   I think so. `ArrayData.is_null` returns false if its `null_bitmap` is `None`. These values are not changed before/after this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org