You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Qian Zhang (JIRA)" <ji...@apache.org> on 2017/06/13 07:53:00 UTC

[jira] [Commented] (MESOS-7656) Update the JSON <=> protobuf message conversion for map support

    [ https://issues.apache.org/jira/browse/MESOS-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047542#comment-16047542 ] 

Qian Zhang commented on MESOS-7656:
-----------------------------------

RR:
https://reviews.apache.org/r/59987/

> Update the JSON <=> protobuf message conversion for map support
> ---------------------------------------------------------------
>
>                 Key: MESOS-7656
>                 URL: https://issues.apache.org/jira/browse/MESOS-7656
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Qian Zhang
>            Assignee: Qian Zhang
>
> [Map|https://developers.google.com/protocol-buffers/docs/proto#maps] is a feature starting from proto2 syntax, but it can only be compiled with proto3 compiler, see the following discussion for details:
> https://groups.google.com/forum/#\!topic/protobuf/p4WxcplrlA4
> We have already upgraded the protobuf compiler from 2.6.1 to 3.3.0 in [MESOS-7228|https://issues.apache.org/jira/browse/MESOS-7228], however, to use protobuf map in Mesos code, we also need to add the protobuf map support to the code in Mesos for converting protobuf message to JSON object and parsing JSON object as protobuf message, that is what we plan to handle in this ticket.
> With map support added, the following field in the protobuf message can be replaced by the native protobuf map field, and we do not have to manually parse it anymore.
> https://github.com/apache/mesos/blob/1.3.0/include/mesos/docker/v1.proto#L68



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)