[GitHub] thrift pull request #977: THRIFT-3768 fix TThreadedServer refactoring issues...

[Jens-G <gi...@git.apache.org>]

Github user Jens-G commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/977#discussion_r67414520
  
    --- Diff: lib/cpp/src/thrift/server/TThreadedServer.h ---
    @@ -20,19 +20,26 @@
     #ifndef _THRIFT_SERVER_TTHREADEDSERVER_H_
     #define _THRIFT_SERVER_TTHREADEDSERVER_H_ 1
     
    -#include <thrift/concurrency/Monitor.h>
     #include <thrift/concurrency/PlatformThreadFactory.h>
     #include <thrift/concurrency/Thread.h>
    -#include <thrift/server/TServerFramework.h>
    +#include <thrift/server/TThreadPoolServer.h>
     
     namespace apache {
     namespace thrift {
     namespace server {
     
     /**
    - * Manage clients using a thread pool.
    + * Manage clients using threads.  Once the refactoring for THRIFT-3083 took place it became
    + * obvious that the differences between the two threaded server types was becoming insignificant.
    + * Therefore to satisfy THRIFT-3096 and fix THRIFT-3768, TThreadedServer is simply a wrapper
    + * around TThreadedPoolServer now.  If backwards compatibility was not a concern, it would have
    + * been removed.
    + *
    + * The default thread pool size is
    --- End diff --
    
    Still the case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---