You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Tim Ellison <t....@gmail.com> on 2007/12/06 17:19:51 UTC
Re: svn commit: r601764 - in /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util:
HashMap.java LinkedHashMap.java
Surely this is new function that should wait until the completion of
this stability drive?
Regards,
Tim
apetrenko@apache.org wrote:
> Author: apetrenko
> Date: Thu Dec 6 07:52:19 2007
> New Revision: 601764
>
> URL: http://svn.apache.org/viewvc?rev=601764&view=rev
> Log:
> Patch for HARMONY-5207 "[classlib][performance] HashMap iterators
> improvements"
>
> Modified:
> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/HashMap.java
> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/LinkedHashMap.java
Re: svn commit: r601764 - in /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util: HashMap.java LinkedHashMap.java
Posted by Mark Hindess <ma...@googlemail.com>.
On 6 December 2007 at 16:19, Tim Ellison <t....@gmail.com> wrote:
>
> Surely this is new function that should wait until the completion of
> this stability drive?
+1
This should definitely have waited for M5.
-Mark.
> apetrenko@apache.org wrote:
> > Author: apetrenko
> > Date: Thu Dec 6 07:52:19 2007
> > New Revision: 601764
> >
> > URL: http://svn.apache.org/viewvc?rev=601764&view=rev
> > Log:
> > Patch for HARMONY-5207 "[classlib][performance] HashMap iterators
> > improvements"
> >
> > Modified:
> > harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Ha
> shMap.java
> > harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Li
> nkedHashMap.java
>
Re: svn commit: r601764 - in /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util: HashMap.java LinkedHashMap.java
Posted by Sergey Dmitriev <se...@gmail.com>.
Tim
Yes, actually there is no big rush. I understand it can be late but
anyway: if this fix breaks the stability - feel free to roll it back.
You say "potato" I say "right, probably this is completely potato". :)
Thanks
Sergey
On Dec 7, 2007 8:45 PM, Tim Ellison <t....@gmail.com> wrote:
> You say "potato" and I say "potato" :-) either way it is a significant
> change to a sensitive part of the core library code just as we are
> trying to stabilize it. Where's the rush? You could add it in eight
> days from now without any argument.
>
> Regards,
> Tim
>
>
>
> Sergey Dmitriev wrote:
> > Tim
> >
> > this is not a new functionality but the performance improvement.
> > Specifically for an application server performance. This should not
> > touch the stability of current Harmony.
> >
> >
> > Thanks
> > Sergey
> >
> >
> > On Dec 6, 2007 7:19 PM, Tim Ellison <t....@gmail.com> wrote:
> >> Surely this is new function that should wait until the completion of
> >> this stability drive?
> >>
> >> Regards,
> >> Tim
> >>
> >> apetrenko@apache.org wrote:
> >>> Author: apetrenko
> >>> Date: Thu Dec 6 07:52:19 2007
> >>> New Revision: 601764
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=601764&view=rev
> >>> Log:
> >>> Patch for HARMONY-5207 "[classlib][performance] HashMap iterators
> >>> improvements"
> >>>
> >>> Modified:
> >>> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/HashMap.java
> >>> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/LinkedHashMap.java
> >
>
Re: svn commit: r601764 - in /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util:
HashMap.java LinkedHashMap.java
Posted by Tim Ellison <t....@gmail.com>.
You say "potato" and I say "potato" :-) either way it is a significant
change to a sensitive part of the core library code just as we are
trying to stabilize it. Where's the rush? You could add it in eight
days from now without any argument.
Regards,
Tim
Sergey Dmitriev wrote:
> Tim
>
> this is not a new functionality but the performance improvement.
> Specifically for an application server performance. This should not
> touch the stability of current Harmony.
>
>
> Thanks
> Sergey
>
>
> On Dec 6, 2007 7:19 PM, Tim Ellison <t....@gmail.com> wrote:
>> Surely this is new function that should wait until the completion of
>> this stability drive?
>>
>> Regards,
>> Tim
>>
>> apetrenko@apache.org wrote:
>>> Author: apetrenko
>>> Date: Thu Dec 6 07:52:19 2007
>>> New Revision: 601764
>>>
>>> URL: http://svn.apache.org/viewvc?rev=601764&view=rev
>>> Log:
>>> Patch for HARMONY-5207 "[classlib][performance] HashMap iterators
>>> improvements"
>>>
>>> Modified:
>>> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/HashMap.java
>>> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/LinkedHashMap.java
>
Re: svn commit: r601764 - in /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util: HashMap.java LinkedHashMap.java
Posted by Sergey Dmitriev <se...@gmail.com>.
Tim
this is not a new functionality but the performance improvement.
Specifically for an application server performance. This should not
touch the stability of current Harmony.
Thanks
Sergey
On Dec 6, 2007 7:19 PM, Tim Ellison <t....@gmail.com> wrote:
> Surely this is new function that should wait until the completion of
> this stability drive?
>
> Regards,
> Tim
>
> apetrenko@apache.org wrote:
> > Author: apetrenko
> > Date: Thu Dec 6 07:52:19 2007
> > New Revision: 601764
> >
> > URL: http://svn.apache.org/viewvc?rev=601764&view=rev
> > Log:
> > Patch for HARMONY-5207 "[classlib][performance] HashMap iterators
> > improvements"
> >
> > Modified:
> > harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/HashMap.java
> > harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/LinkedHashMap.java
>