You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/21 19:55:20 UTC
[GitHub] [superset] rubypollev opened a new issue #16766: Absolute value diff is incorrect
rubypollev opened a new issue #16766:
URL: https://github.com/apache/superset/issues/16766
Absolute value diff is `t1 - t2` when it should be `|t1 - t2\`. The absolute value function is not being applied.
https://github.com/apache/superset/blob/4e3d4f6daf01749b8f28e0770e138db5ed8fae91/superset/viz.py#L1433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rubypollev commented on issue #16766: Absolute value diff is incorrect
Posted by GitBox <gi...@apache.org>.
rubypollev commented on issue #16766:
URL: https://github.com/apache/superset/issues/16766#issuecomment-929392087
Tableau's implementation makes sense. This is a "difference." It can be negative.
Superset's implementation claims this same function is an "absolute difference," though, which it's not:
<img width="1538" alt="time_comparison_absolute_difference" src="https://user-images.githubusercontent.com/45610410/135128264-8142b9b0-a3c0-4831-8674-069c5c4325b3.png">
An [absolute difference](https://en.wikipedia.org/wiki/Absolute_difference) is non-negative by definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rubypollev commented on issue #16766: Absolute value diff is incorrect
Posted by GitBox <gi...@apache.org>.
rubypollev commented on issue #16766:
URL: https://github.com/apache/superset/issues/16766#issuecomment-929392087
Tableau's implementation makes sense. This is a "difference." It can be negative.
Superset's implementation claims this same function is an "absolute difference," though, which it's not:
<img width="1538" alt="time_comparison_absolute_difference" src="https://user-images.githubusercontent.com/45610410/135128264-8142b9b0-a3c0-4831-8674-069c5c4325b3.png">
An [absolute difference](https://en.wikipedia.org/wiki/Absolute_difference) is non-negative by definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #16766: Absolute value diff is incorrect
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #16766:
URL: https://github.com/apache/superset/issues/16766#issuecomment-928909955
@rubypollev The absolute function is not necessarily applied to diff results. cc: @junlincc
`diff` In the tableau
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie closed issue #16766: Absolute value diff is incorrect
Posted by GitBox <gi...@apache.org>.
zhaoyongjie closed issue #16766:
URL: https://github.com/apache/superset/issues/16766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #16766: Absolute value diff is incorrect
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #16766:
URL: https://github.com/apache/superset/issues/16766#issuecomment-928909955
@rubypollev The absolute function is not necessarily applied to diff results. cc: @junlincc
`diff` In the tableau
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #16766: Absolute value diff is incorrect
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #16766:
URL: https://github.com/apache/superset/issues/16766#issuecomment-931899664
Hi @rubypollev, thanks for your Issue, I will fix it asap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org