You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by zhuoliu <gi...@git.apache.org> on 2015/09/23 21:38:03 UTC
[GitHub] storm pull request: [STORM-1063] support relative log4j conf dir f...
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/760
[STORM-1063] support relative log4j conf dir for both daemons and workers
An easier fix might be dropping the default configuration of "log4j" and force users to provide complete path, however, we still prefer to support relative path of log4j conf dir.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm 1063
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/760.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #760
----
commit 94b156243eef1cef6e572e94918ac4153a0f82cf
Author: zhuol <zh...@yahoo-inc.com>
Date: 2015-09-23T19:37:06Z
[STORM-1063] fix log4j conf dir relative path issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1063] support relative log4j conf dir f...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/760#issuecomment-144137713
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1063] support relative log4j conf dir f...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/760#issuecomment-144190457
+1 looks great, thanks for doing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1063] support relative log4j conf dir f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/760
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1063] support relative log4j conf dir f...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/760#issuecomment-142772757
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---