[impala] 02/02: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api

[cs...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

csringhofer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit f41a1887fd85f526d32ef917c3ba94c6902e7e98
Author: Csaba Ringhofer <cs...@cloudera.com>
AuthorDate: Mon Oct 14 17:22:38 2019 +0200

    IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api
    
    The previous commit for this Jira serialized the compilation of
    shaded-deps and ext-data-source to fix flakiness. It looks like
    this led to a new similar issue related to the parallel compilation
    of ext-data-source and query-event-hook-api.
    
    Similarly to the shaded-deps issue, I try to fix this by adding a
    fictional dependency (query-event-hook-api -> yarn-extras) to serialize
    the build.
    
    Full Maven dependency graph:
    fe -> query-event-hook-api -> yarn-extras -> ext-data-source ->
         shaded-deps-> impala-parent
    The ordering of query-event-hook-apit, yarn-extras, ext-data-source,
    and shaded-deps are arbitrary.
    
    Change-Id: Ice0dfda5ee0ef60c9c208f05b0952555770fc090
    Reviewed-on: http://gerrit.cloudera.org:8080/14423
    Reviewed-by: Joe McDonnell <jo...@cloudera.com>
    Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
    Tested-by: Csaba Ringhofer <cs...@cloudera.com>
---
 query-event-hook-api/CMakeLists.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/query-event-hook-api/CMakeLists.txt b/query-event-hook-api/CMakeLists.txt
index 700e614..7352ed2 100644
--- a/query-event-hook-api/CMakeLists.txt
+++ b/query-event-hook-api/CMakeLists.txt
@@ -15,6 +15,8 @@
 # specific language governing permissions and limitations
 # under the License.
 
-add_custom_target(query-event-hook-api ALL DEPENDS gen-deps impala-parent
+# The dependency on yarn-extras is only added to avoid parallel downloads
+# of dependencies. For more details see IMPALA-7051, which was a similar issue.
+add_custom_target(query-event-hook-api ALL DEPENDS gen-deps impala-parent yarn-extras
   COMMAND $ENV{IMPALA_HOME}/bin/mvn-quiet.sh -B install -DskipTests
 )