[GitHub] [skywalking] wu-sheng commented on a change in pull request #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4320: [BUG]Fix the bug of port identification failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: < port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320#discussion_r375071553
 
 

 ##########
 File path: apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/connectionurl/parser/OracleURLParser.java
 ##########
 @@ -94,6 +94,10 @@ private ConnectionInfo commonsURLParse() {
         String[] hostSegment = splitDatabaseAddress(host);
         String databaseName = fetchDatabaseNameFromURL();
         if (hostSegment.length == 1) {
+            if (databaseName.contains("/") && databaseName.split("/").length == 2) {
+                String[] portAndDatabaseName = databaseName.split("/");
+                return new ConnectionInfo(ComponentsDefine.OJDBC, DB_TYPE, host, Integer.valueOf(portAndDatabaseName[0]), portAndDatabaseName[1]);
+            }
 
 Review comment:
   Where is the `else`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services