You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Joe Bowser (JIRA)" <ji...@apache.org> on 2012/10/25 01:50:12 UTC

[jira] [Created] (CB-1741) Our geolocation plugin is missing timeout and maximumAge attributes

Joe Bowser created CB-1741:
------------------------------

             Summary: Our geolocation plugin is missing timeout and maximumAge attributes
                 Key: CB-1741
                 URL: https://issues.apache.org/jira/browse/CB-1741
             Project: Apache Cordova
          Issue Type: Bug
          Components: Android
    Affects Versions: 2.1.0
            Reporter: Joe Bowser
            Assignee: Joe Bowser
             Fix For: 2.3.0


After this discussion on the Google Group (https://groups.google.com/forum/?fromgroups=#!topic/phonegap/Ivoj7oiVwfU), I realized that we don't implement a timeout or a maximum age for cached locations in our geolocation plugin.  We need to implement this on Android at the very least.  Other platforms should also check against the Geolocation Spec.

http://dev.w3.org/geo/api/spec-source.html#timeout



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CB-1741) Our geolocation plugin is missing timeout and maximumAge attributes

Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bowser resolved CB-1741.
----------------------------

    Resolution: Fixed

OK, my mistake.  I was looking at Java code, not the common JS.  Mea culpa.
                
> Our geolocation plugin is missing timeout and maximumAge attributes
> -------------------------------------------------------------------
>
>                 Key: CB-1741
>                 URL: https://issues.apache.org/jira/browse/CB-1741
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 2.1.0
>            Reporter: Joe Bowser
>            Assignee: Joe Bowser
>             Fix For: 2.3.0
>
>
> After this discussion on the Google Group (https://groups.google.com/forum/?fromgroups=#!topic/phonegap/Ivoj7oiVwfU), I realized that we don't implement a timeout or a maximum age for cached locations in our geolocation plugin.  We need to implement this on Android at the very least.  Other platforms should also check against the Geolocation Spec.
> http://dev.w3.org/geo/api/spec-source.html#timeout

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1741) Our geolocation plugin is missing timeout and maximumAge attributes

Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483743#comment-13483743 ] 

Filip Maj commented on CB-1741:
-------------------------------

Our geolocation common module in JS caches all positions returned by the native framework:

- [{{getCurrentPosition}} does this|https://github.com/apache/incubator-cordova-js/blob/master/lib/common/plugin/geolocation.js#L108].
- [so does {{watchPosition}}|https://github.com/apache/incubator-cordova-js/blob/master/lib/common/plugin/geolocation.js#L192].

Finally, {{getCurrentPosition}} [checks whether we have a cached position and compares the timestamp to the maximumAge parameters|https://github.com/apache/incubator-cordova-js/blob/master/lib/common/plugin/geolocation.js#L122].
                
> Our geolocation plugin is missing timeout and maximumAge attributes
> -------------------------------------------------------------------
>
>                 Key: CB-1741
>                 URL: https://issues.apache.org/jira/browse/CB-1741
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 2.1.0
>            Reporter: Joe Bowser
>            Assignee: Joe Bowser
>             Fix For: 2.3.0
>
>
> After this discussion on the Google Group (https://groups.google.com/forum/?fromgroups=#!topic/phonegap/Ivoj7oiVwfU), I realized that we don't implement a timeout or a maximum age for cached locations in our geolocation plugin.  We need to implement this on Android at the very least.  Other platforms should also check against the Geolocation Spec.
> http://dev.w3.org/geo/api/spec-source.html#timeout

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira