You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2026/01/28 05:19:07 UTC

[PR] [SPARK-55250][SQL] Reduce Hive client calls on CREATE NAMESPACE [spark]

pan3793 opened a new pull request, #54026:
URL: https://github.com/apache/spark/pull/54026

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'common/utils/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   This PR reduces Hive client calls by eliminating unnecessary `catalog.databaseExists` in `CreateNamespaceExec`. Now the Hive client calls of `CREATE NAMESPACE [IF NOT EXISTS] foo.bar` decreased from 3 to 1.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Improve perf by reducing RPC.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
   
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   UT is added.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   <!--
   If generative AI tooling has been used in the process of authoring this patch, please include the
   phrase: 'Generated-by: ' followed by the name of the tool and its version.
   If no, write 'No'.
   Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
   -->
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55250][SQL] Reduce Hive client calls on CREATE NAMESPACE [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54026:
URL: https://github.com/apache/spark/pull/54026#issuecomment-3809033592

   ## JIRA Issue Information
   
   === Improvement SPARK-55250 ===
   Summary: Reduce Hive client calls on CREATE NAMESPACE
   Assignee: None
   Status: Open
   Affected: ["4.2.0"]
   
   ---
   *This comment was automatically generated by GitHub Actions*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55250][SQL] Reduce Hive client calls on CREATE NAMESPACE [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #54026:
URL: https://github.com/apache/spark/pull/54026#discussion_r2736080840


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateNamespaceExec.scala:
##########
@@ -37,22 +38,14 @@ case class CreateNamespaceExec(
     private var properties: Map[String, String])
     extends LeafV2CommandExec {
   override protected def run(): Seq[InternalRow] = {
-    import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
-    import org.apache.spark.sql.connector.catalog.SupportsNamespaces._
-
     val ns = namespace.toArray
-    if (!catalog.namespaceExists(ns)) {
-      try {
-        val ownership =
-          Map(PROP_OWNER -> Utils.getCurrentUserName())
-        catalog.createNamespace(ns, (properties ++ ownership).asJava)
-      } catch {
-        case _: NamespaceAlreadyExistsException if ifNotExists =>
-          logWarning(log"Namespace ${MDC(NAMESPACE, namespace.quoted)} was created concurrently. " +
-            log"Ignoring.")
-      }
-    } else if (!ifNotExists) {
-      throw QueryCompilationErrors.namespaceAlreadyExistsError(ns)
+    try {
+      val ownership = Map(PROP_OWNER -> Utils.getCurrentUserName())
+      catalog.createNamespace(ns, (properties ++ ownership).asJava)
+    } catch {
+      case _: NamespaceAlreadyExistsException if ifNotExists =>

Review Comment:
   can you pint out where Spark throws `NamespaceAlreadyExistsException`? In `HiveExternalCatalog` or `HiveClient`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55250][SQL] Reduce Hive client calls on CREATE NAMESPACE [spark]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #54026:
URL: https://github.com/apache/spark/pull/54026#discussion_r2734947018


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateNamespaceExec.scala:
##########
@@ -37,22 +38,14 @@ case class CreateNamespaceExec(
     private var properties: Map[String, String])
     extends LeafV2CommandExec {
   override protected def run(): Seq[InternalRow] = {
-    import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
-    import org.apache.spark.sql.connector.catalog.SupportsNamespaces._
-
     val ns = namespace.toArray
-    if (!catalog.namespaceExists(ns)) {

Review Comment:
   we don't need this check because `createNamespace` will throw `NamespaceAlreadyExistsException` if the namespace already exists, by contract.
   
   https://github.com/apache/spark/blob/9ce067c7d532a6766d622e55164baa942a065250/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsNamespaces.java#L121-L131
   
   this also makes it atomic, previously, there are chance that the namespace is created by another request between `catalog.namespaceExists` and `catalog.createNamespace`, we should delegate it to the Connector to handle that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55250][SQL] Reduce Hive client calls on CREATE NAMESPACE [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #54026:
URL: https://github.com/apache/spark/pull/54026#issuecomment-3811098363

   thanks, merging to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55250][SQL] Reduce Hive client calls on CREATE NAMESPACE [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #54026: [SPARK-55250][SQL] Reduce Hive client calls on CREATE NAMESPACE
URL: https://github.com/apache/spark/pull/54026


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55250][SQL] Reduce Hive client calls on CREATE NAMESPACE [spark]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #54026:
URL: https://github.com/apache/spark/pull/54026#discussion_r2736129178


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateNamespaceExec.scala:
##########
@@ -37,22 +38,14 @@ case class CreateNamespaceExec(
     private var properties: Map[String, String])
     extends LeafV2CommandExec {
   override protected def run(): Seq[InternalRow] = {
-    import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
-    import org.apache.spark.sql.connector.catalog.SupportsNamespaces._
-
     val ns = namespace.toArray
-    if (!catalog.namespaceExists(ns)) {
-      try {
-        val ownership =
-          Map(PROP_OWNER -> Utils.getCurrentUserName())
-        catalog.createNamespace(ns, (properties ++ ownership).asJava)
-      } catch {
-        case _: NamespaceAlreadyExistsException if ifNotExists =>
-          logWarning(log"Namespace ${MDC(NAMESPACE, namespace.quoted)} was created concurrently. " +
-            log"Ignoring.")
-      }
-    } else if (!ifNotExists) {
-      throw QueryCompilationErrors.namespaceAlreadyExistsError(ns)
+    try {
+      val ownership = Map(PROP_OWNER -> Utils.getCurrentUserName())
+      catalog.createNamespace(ns, (properties ++ ownership).asJava)
+    } catch {
+      case _: NamespaceAlreadyExistsException if ifNotExists =>

Review Comment:
   happens here
   https://github.com/apache/spark/blob/589fedc9b231f49a8cf808ac901fbdb3f44de271/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala#L345-L355
   
   https://github.com/apache/spark/blob/589fedc9b231f49a8cf808ac901fbdb3f44de271/sql/api/src/main/scala/org/apache/spark/sql/catalyst/analysis/alreadyExistException.scala#L31-L32



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55250][SQL] Reduce Hive client calls on CREATE NAMESPACE [spark]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #54026:
URL: https://github.com/apache/spark/pull/54026#discussion_r2736129178


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateNamespaceExec.scala:
##########
@@ -37,22 +38,14 @@ case class CreateNamespaceExec(
     private var properties: Map[String, String])
     extends LeafV2CommandExec {
   override protected def run(): Seq[InternalRow] = {
-    import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
-    import org.apache.spark.sql.connector.catalog.SupportsNamespaces._
-
     val ns = namespace.toArray
-    if (!catalog.namespaceExists(ns)) {
-      try {
-        val ownership =
-          Map(PROP_OWNER -> Utils.getCurrentUserName())
-        catalog.createNamespace(ns, (properties ++ ownership).asJava)
-      } catch {
-        case _: NamespaceAlreadyExistsException if ifNotExists =>
-          logWarning(log"Namespace ${MDC(NAMESPACE, namespace.quoted)} was created concurrently. " +
-            log"Ignoring.")
-      }
-    } else if (!ifNotExists) {
-      throw QueryCompilationErrors.namespaceAlreadyExistsError(ns)
+    try {
+      val ownership = Map(PROP_OWNER -> Utils.getCurrentUserName())
+      catalog.createNamespace(ns, (properties ++ ownership).asJava)
+    } catch {
+      case _: NamespaceAlreadyExistsException if ifNotExists =>

Review Comment:
   happens here
   https://github.com/apache/spark/blob/589fedc9b231f49a8cf808ac901fbdb3f44de271/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala#L345-L355



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org