You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Justin Ross (Jira)" <ji...@apache.org> on 2021/03/30 18:53:00 UTC
[jira] [Updated] (PROTON-2248) [c] Codec pn_data_vfill() method has
symbol and string types interchanged
[ https://issues.apache.org/jira/browse/PROTON-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Ross updated PROTON-2248:
--------------------------------
Summary: [c] Codec pn_data_vfill() method has symbol and string types interchanged (was: [c] Codec pn_data_vfill() method has symbol and string types interchanged.)
> [c] Codec pn_data_vfill() method has symbol and string types interchanged
> -------------------------------------------------------------------------
>
> Key: PROTON-2248
> URL: https://issues.apache.org/jira/browse/PROTON-2248
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Reporter: Kim van der Riet
> Priority: Major
>
> The *{{pn_data_vfill()}}* method in codec.c:571 has the symbol and string types interchanged. The function documentation states:
> {noformat}
> /* Format codes:
> code: AMQP-type (arguments)
> ...
> S: symbol (char*)
> s: string (char*)
> ...
> */
> {noformat}
> but uses these the other way around, ie {{s}} for symbol and {{S}} for string:
> {noformat}
> if (code == 'S') {
> err = pn_data_put_string(data, pn_bytes(size, start));
> } else {
> err = pn_data_put_symbol(data, pn_bytes(size, start));
> }
> {noformat}
> Guidance is needed on whether to fix the reversal and keep the stated codes, or reverse the codes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org