You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/13 00:49:49 UTC
[GitHub] [airflow] kaxil opened a new pull request #17597: Use built-in ``cached_property`` on Python 3.8 for Asana provider
kaxil opened a new pull request #17597:
URL: https://github.com/apache/airflow/pull/17597
Functionality is the same, this just removes one dep for Py 3.8+
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17597: Use built-in ``cached_property`` on Python 3.8 for Asana provider
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17597:
URL: https://github.com/apache/airflow/pull/17597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #17597: Use built-in ``cached_property`` on Python 3.8 for Asana provider
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #17597:
URL: https://github.com/apache/airflow/pull/17597#issuecomment-898329117
> Oops, I missed #14606 and it’s already merged. There’s actually a shim for this:
>
> ```python
> from airflow.compat.functools import cached_property
> ```
>
> And it handles type hint better; I added a `functools.pyi` file to manually provide the annotation.
I intentionally skipped providers so that users can use this version of provider in older version of Airflow that does not contain `from airflow.compat.functools` module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17597: Use built-in ``cached_property`` on Python 3.8 for Asana provider
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17597:
URL: https://github.com/apache/airflow/pull/17597#issuecomment-898348584
Got it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17597: Use built-in ``cached_property`` on Python 3.8 for Asana provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17597:
URL: https://github.com/apache/airflow/pull/17597#issuecomment-898349023
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17597: Use built-in ``cached_property`` on Python 3.8 for Asana provider
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17597:
URL: https://github.com/apache/airflow/pull/17597#issuecomment-898318923
Oops, I missed #14606 and it’s already merged. There’s actually a shim for this:
```python
from airflow.compat.functools import cached_property
```
And it handles type hint better; I added a `functools.pyi` file to manually provide the annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org