You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ce...@apache.org on 2019/01/22 10:01:36 UTC

svn commit: r1851796 - /poi/trunk/build.xml

Author: centic
Date: Tue Jan 22 10:01:36 2019
New Revision: 1851796

URL: http://svn.apache.org/viewvc?rev=1851796&view=rev
Log:
Fix passing in --add-opens for Java 9+ after the poiunit refactoring, this
only caused problems with Java 9+ on Windows, which we do not run in CI (yet)

Modified:
    poi/trunk/build.xml

Modified: poi/trunk/build.xml
URL: http://svn.apache.org/viewvc/poi/trunk/build.xml?rev=1851796&r1=1851795&r2=1851796&view=diff
==============================================================================
--- poi/trunk/build.xml (original)
+++ poi/trunk/build.xml Tue Jan 22 10:01:36 2019
@@ -1229,15 +1229,15 @@ under the License.
                     <jvmarg value="-Xmx@{heap}M"/>
                     <jvmarg value="-ea"/>
 
-                    <!-- these need to be set differently when running with Java 9 -->
-                    <jvmarg value="${java9addmods}" if:set="${java9addmods}" />
-                    <jvmarg value="${java9addmodsvalue}" if:set="${java9addmodsvalue}" />
-                    <jvmarg value="${java9addopens1}" if:set="${java9addopens1}" />
-                    <jvmarg value="${java9addopens2}" if:set="${java9addopens2}" />
-                    <jvmarg value="${java9addopens3}" if:set="${java9addopens3}" />
-                    <jvmarg value="${java9addopens4}" if:set="${java9addopens4}" />
-                    <jvmarg value="${java9addopens5}" if:set="${java9addopens5}" />
-                    <jvmarg value="${java9addopens6}" if:set="${java9addopens6}" />
+                    <!-- some --add-opens and other properties are needed when running with Java 9 or newer -->
+                    <jvmarg value="${java9addmods}" if:set="java9addmods" />
+                    <jvmarg value="${java9addmodsvalue}" if:set="java9addmodsvalue" />
+                    <jvmarg value="${java9addopens1}" if:set="java9addopens1" />
+                    <jvmarg value="${java9addopens2}" if:set="java9addopens2" />
+                    <jvmarg value="${java9addopens3}" if:set="java9addopens3" />
+                    <jvmarg value="${java9addopens4}" if:set="java9addopens4" />
+                    <jvmarg value="${java9addopens5}" if:set="java9addopens5" />
+                    <jvmarg value="${java9addopens6}" if:set="java9addopens6}" />
 
                     <jvmarg value="-javaagent:${ooxml.lite.agent}=${ooxml.lite.report}|${ooxml.lite.includes}" if:true="${ooxml.lite.agent.exists}"/>
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org