You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/07/07 10:53:45 UTC

[GitHub] [druid] clintropolis commented on a change in pull request #10137: Add additional properties for Kafka AdminClient and consumer from test config file

clintropolis commented on a change in pull request #10137:
URL: https://github.com/apache/druid/pull/10137#discussion_r450005227



##########
File path: integration-tests/src/test/java/org/apache/druid/tests/indexer/AbstractKafkaIndexingServiceTest.java
##########
@@ -37,7 +38,7 @@
   @Override
   StreamAdminClient createStreamAdminClient(IntegrationTestingConfig config)
   {
-    return new KafkaAdminClient(config.getKafkaHost());
+    return new KafkaAdminClient(config.getKafkaHost(), config);

Review comment:
       Should the `KafkaAdminClient` constructor signature be adjusted to only take `IntegrationTestingConfig ` and just set `host` inside the constructor from it instead of extracting here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org