You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "James Dyer (JIRA)" <ji...@apache.org> on 2012/11/15 23:59:12 UTC
[jira] [Created] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
James Dyer created SOLR-4086:
--------------------------------
Summary: Refactor DIH - VariableResolver & Evaluator
Key: SOLR-4086
URL: https://issues.apache.org/jira/browse/SOLR-4086
Project: Solr
Issue Type: Improvement
Components: contrib - DataImportHandler
Affects Versions: 4.0
Reporter: James Dyer
Assignee: James Dyer
Priority: Minor
Fix For: 4.1, 5.0
This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500362#comment-13500362 ]
Mark Miller commented on SOLR-4086:
-----------------------------------
looks like this triggered a jenkins fail due to tabs,nocommit, or author tag.
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498433#comment-13498433 ]
Uwe Schindler commented on SOLR-4086:
-------------------------------------
Does this fix all default Locale bugs in DIH? If yes, you should remove the DIH class file exclusion from the API violations checker in solr/build.xml.
I am happy, that you are taking care, thanks!
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502052#comment-13502052 ]
Commit Tag Bot commented on SOLR-4086:
--------------------------------------
[trunk commit] James Dyer
http://svn.apache.org/viewvc?view=revision&revision=1411370
SOLR-4086: fix TestVariableResolver
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
Posted by "James Dyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer resolved SOLR-4086.
------------------------------
Resolution: Fixed
Committed.
Trunk: r1411276
4x: r1411280
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498455#comment-13498455 ]
Robert Muir commented on SOLR-4086:
-----------------------------------
{quote}
I am happy, that you are taking care, thanks!
{quote}
+1 to that!
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502046#comment-13502046 ]
Commit Tag Bot commented on SOLR-4086:
--------------------------------------
[branch_4x commit] James Dyer
http://svn.apache.org/viewvc?view=revision&revision=1411371
SOLR-4086: fix residual problems with DateFormatEvaluator
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502055#comment-13502055 ]
Commit Tag Bot commented on SOLR-4086:
--------------------------------------
[trunk commit] James Dyer
http://svn.apache.org/viewvc?view=revision&revision=1411334
SOLR-4086: fix dateformat evaluator unit test
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502053#comment-13502053 ]
Commit Tag Bot commented on SOLR-4086:
--------------------------------------
[trunk commit] James Dyer
http://svn.apache.org/viewvc?view=revision&revision=1411366
SOLR-4086: fix residual problems with DateFormatEvaluator
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
Posted by "James Dyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-4086:
-----------------------------
Attachment: SOLR-4086.patch
This is a big patch, but much of it is from moving code. All tests pass with this applied.
My plan is to commit this in a few days.
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502054#comment-13502054 ]
Commit Tag Bot commented on SOLR-4086:
--------------------------------------
[trunk commit] James Dyer
http://svn.apache.org/viewvc?view=revision&revision=1411357
SOLR-4086: fix TestVariableResolver
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504147#comment-13504147 ]
Commit Tag Bot commented on SOLR-4086:
--------------------------------------
[trunk commit] James Dyer
http://svn.apache.org/viewvc?view=revision&revision=1413729
SOLR-4086: fix trivial test mistake
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
Posted by "James Dyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498511#comment-13498511 ]
James Dyer commented on SOLR-4086:
----------------------------------
I don't believe it fixes all of SOLR-1916, and certainly doesn't eliminate all the forbidden API's (that API checker is very handy, by the way). But I think this takes a good bite out of it and hopefully soon we can remove the DIH exclusion.
We might also be able to eventually run DIH tests in parallel also now that SOLR-4051 gives the ability to specify the location of the "dataimport.properties" file. Tests need to be changed to take advantage first though.
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-4086) Refactor DIH - VariableResolver &
Evaluator
Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502047#comment-13502047 ]
Commit Tag Bot commented on SOLR-4086:
--------------------------------------
[branch_4x commit] James Dyer
http://svn.apache.org/viewvc?view=revision&revision=1411348
SOLR-4086: fix dateformat evaluator unit test
> Refactor DIH - VariableResolver & Evaluator
> -------------------------------------------
>
> Key: SOLR-4086
> URL: https://issues.apache.org/jira/browse/SOLR-4086
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4086.patch
>
>
> This simplifies VariableResolver and moves each built-in Evaluator into its own class. Compiler warnings / missing generics are fixed. Also, the Locale bug with DateFormatEvaluator is solved. Instead of using the machine default, the Root Locale is used by default. An optional 3rd parameter allows users to specify whatever locale they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org