You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Andrea Pescetti <pe...@apache.org> on 2015/05/01 19:33:46 UTC
Re: [DISCUSS] Future of the Hangul Word Processor, HWP, filter
On 29/04/2015 Andrea Pescetti wrote:
> The only reasonable solution indeed seems to remove the filter. I opened
> a 4.1.2 issue at
> https://bz.apache.org/ooo/show_bug.cgi?id=126281
Seeing that we have lazy consensus on the idea of simply removing the
filter, I've started the cleanup work.
The first commit
https://svn.apache.org/viewvc?view=revision&revision=1677190
already fixes the vulnerability since it prevents the library from being
built and included in the packages we distribute.
Reviewers wanted! I already welcome reviews on the first commit, but
this is only the initial part.
I'll make other commits to complete the cleanup (for example, removing
hwpfilter from include paths, drop support for the .hwp file extension,
remove a special license paragraph related to HWP, remove it from the
RAT scan exceptions list) unless someone else volunteers to take care of
those.
Regards,
Andrea.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [DISCUSS] Future of the Hangul Word Processor, HWP, filter
Posted by Andrea Pescetti <pe...@apache.org>.
On 08/05/2015 Kay Schenk wrote:
> I didn't have any problems with my build after your changes. But, I did
> notice that the Hangul file type was still listed in the menu choices
> for import.
I had taken a look at this too, and I think the examples I mentioned are
very useful as a reference: the cleanup may involve many details, but it
is not very complex. Unfortunately, I won't have time to spend on this
in the coming days, so feel free to continue.
I suggest that we consider the issue
https://bz.apache.org/ooo/show_bug.cgi?id=126281 closed as of May 1st
(when I made the relevant commit) and that we open a new one for the
"Hangul Word Processor filter cleanup" where we can put these small
secondary fixes.
Regards,
Andrea.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [DISCUSS] Future of the Hangul Word Processor, HWP, filter
Posted by Kay Schenk <ka...@gmail.com>.
On 05/03/2015 11:49 PM, Andrea Pescetti wrote:
> On 03/05/2015 Marcus wrote:
>> that's great to see. :-) Didn't know that you had such deep knowledge of
>> the code.
>
> Honestly, as someone (I think it was Pedro) once put it, to remove stuff
> you just need an axe (sometimes a well-sharpened axe), and not a deep
> knowledge of the code!
>
> I will test stuff on the Linux version only. Our buildbots are not in
> great shape
> http://ci.apache.org/projects/openoffice/
> so (without reopening a discussion on installing new ones, please) we
> should also look at fixing them to be able to find regressions quickly.
>
> Regards,
> Andrea.
I didn't have any problems with my build after your changes. But, I did
notice that the Hangul file type was still listed in the menu choices
for import. However, when I removed these yesterday --
/main/filter/source/config/fragments/filters/writer_MIZI_Hwp_97.xcu
/main/filter/source/config/fragments/types/writer_MIZI_Hwp_97.xcu
the build failed on the "filter" module. I will look into this further
and provide more information later. I think keeping these menu entries
would be confusing to users.
--
-------------------------------------------------------------------------
MzK
“What is the point of being alive if you don't
at least try to do something remarkable?”
-- John Green, "An Abundance of Katherines"
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: Buildbot Builds
Posted by Marcus <ma...@wtnet.de>.
Am 05/06/2015 11:26 AM, schrieb Gavin McDonald:
>> On 4 May 2015, at 7:49 am, Andrea Pescetti<pe...@apache.org> wrote:
>>
>> <snip>
>
>> I will test stuff on the Linux version only. Our buildbots are not in great shape
>> http://ci.apache.org/projects/openoffice/
>> so (without reopening a discussion on installing new ones, please) we should also look at fixing them to be able to find regressions quickly.
>
> I’ll do what I can wrt to the Buildbot builds and setup so expect some mails from me on this.
> Note that this is my ‘volunteer time’ so although my infra karma will help I’m not wearing that hat.
thanks a lot for helping out in this special area - and for sharing your
really little spare time. :-)
Marcus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: Buildbot Builds
Posted by jan i <ja...@apache.org>.
On 6 May 2015 at 11:26, Gavin McDonald <gm...@apache.org> wrote:
>
>
> > On 4 May 2015, at 7:49 am, Andrea Pescetti <pe...@apache.org> wrote:
> >
> > <snip>
>
> > I will test stuff on the Linux version only. Our buildbots are not in
> great shape
> > http://ci.apache.org/projects/openoffice/
> > so (without reopening a discussion on installing new ones, please) we
> should also look at fixing them to be able to find regressions quickly.
>
> I’ll do what I can wrt to the Buildbot builds and setup so expect some
> mails from me on this.
> Note that this is my ‘volunteer time’ so although my infra karma will help
> I’m not wearing that hat.
>
Thanks a lot for helping out, I actually think your buildbot experience is
more important than your infra hat for this.
rgds
jan I.
>
> Gav…
>
>
Buildbot Builds
Posted by Gavin McDonald <gm...@apache.org>.
> On 4 May 2015, at 7:49 am, Andrea Pescetti <pe...@apache.org> wrote:
>
> <snip>
> I will test stuff on the Linux version only. Our buildbots are not in great shape
> http://ci.apache.org/projects/openoffice/
> so (without reopening a discussion on installing new ones, please) we should also look at fixing them to be able to find regressions quickly.
I’ll do what I can wrt to the Buildbot builds and setup so expect some mails from me on this.
Note that this is my ‘volunteer time’ so although my infra karma will help I’m not wearing that hat.
Gav…
Re: [DISCUSS] Future of the Hangul Word Processor, HWP, filter
Posted by Andrea Pescetti <pe...@apache.org>.
On 03/05/2015 Marcus wrote:
> that's great to see. :-) Didn't know that you had such deep knowledge of
> the code.
Honestly, as someone (I think it was Pedro) once put it, to remove stuff
you just need an axe (sometimes a well-sharpened axe), and not a deep
knowledge of the code!
I will test stuff on the Linux version only. Our buildbots are not in
great shape
http://ci.apache.org/projects/openoffice/
so (without reopening a discussion on installing new ones, please) we
should also look at fixing them to be able to find regressions quickly.
Regards,
Andrea.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [DISCUSS] Future of the Hangul Word Processor, HWP, filter
Posted by Marcus <ma...@wtnet.de>.
Am 05/01/2015 07:33 PM, schrieb Andrea Pescetti:
> On 29/04/2015 Andrea Pescetti wrote:
>> The only reasonable solution indeed seems to remove the filter. I opened
>> a 4.1.2 issue at
>> https://bz.apache.org/ooo/show_bug.cgi?id=126281
>
> Seeing that we have lazy consensus on the idea of simply removing the
> filter, I've started the cleanup work.
that's great to see. :-) Didn't know that you had such deep knowledge of
the code.
Marcus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org