You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/08 14:15:46 UTC
[GitHub] [apisix] membphis opened a new pull request #2364: feat: add new filed `meta_style`, collect the request information with `original` style.
membphis opened a new pull request #2364:
URL: https://github.com/apache/apisix/pull/2364
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
feat: add new filed `meta_style`, collect the request information with `original` style.
eg:
```
send data to kafka: POST /hello?ab=cd HTTP/1.1
host: localhost
content-length: 6
connection: close
abcdef
```
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming merged pull request #2364: feat: add new filed `meta_style`, collect the request information with `original` style.
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #2364:
URL: https://github.com/apache/apisix/pull/2364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on a change in pull request #2364: feat: add new filed `meta_style`, collect the request information with `original` style.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #2364:
URL: https://github.com/apache/apisix/pull/2364#discussion_r502171779
##########
File path: apisix/plugins/kafka-logger.lua
##########
@@ -32,6 +32,11 @@ local buffers = {}
local schema = {
type = "object",
properties = {
+ meta_style = {
Review comment:
yes, `meta_format` is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2364: feat: add new filed `meta_style`, collect the request information with `original` style.
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2364:
URL: https://github.com/apache/apisix/pull/2364#issuecomment-705930508
will add today
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on a change in pull request #2364: feat: add new filed `meta_style`, collect the request information with `original` style.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #2364:
URL: https://github.com/apache/apisix/pull/2364#discussion_r502171779
##########
File path: apisix/plugins/kafka-logger.lua
##########
@@ -32,6 +32,11 @@ local buffers = {}
local schema = {
type = "object",
properties = {
+ meta_style = {
Review comment:
yes, `meta_format` is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2364: feat: add new filed `meta_style`, collect the request information with `original` style.
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2364:
URL: https://github.com/apache/apisix/pull/2364#issuecomment-705930508
will add today
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming merged pull request #2364: feat: add new filed `meta_style`, collect the request information with `original` style.
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #2364:
URL: https://github.com/apache/apisix/pull/2364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2364: feat: add new filed `meta_style`, collect the request information with `original` style.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2364:
URL: https://github.com/apache/apisix/pull/2364#discussion_r502162916
##########
File path: apisix/plugins/kafka-logger.lua
##########
@@ -32,6 +32,11 @@ local buffers = {}
local schema = {
type = "object",
properties = {
+ meta_style = {
Review comment:
`meta_format` maybe a better name.
any suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2364: feat: add new filed `meta_style`, collect the request information with `original` style.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2364:
URL: https://github.com/apache/apisix/pull/2364#discussion_r502162916
##########
File path: apisix/plugins/kafka-logger.lua
##########
@@ -32,6 +32,11 @@ local buffers = {}
local schema = {
type = "object",
properties = {
+ meta_style = {
Review comment:
`meta_format` maybe a better name.
any suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org