You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/16 09:33:38 UTC

[GitHub] [orc] dongjoon-hyun opened a new pull request #912: ORC-1002: Add java17 profile for Java17 unit testing

dongjoon-hyun opened a new pull request #912:
URL: https://github.com/apache/orc/pull/912


   ### What changes were proposed in this pull request?
   
   This PR aims to add `java17` profile for Java 17 Unit testing.
   
   ### Why are the changes needed?
   
   This is required because Java 17 is supported by Hadoop 3.3.
   
   ### How was this patch tested?
   
   Pass the CIs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #912: ORC-1002: Add `java17` profile to support Java 17 unit testing

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #912:
URL: https://github.com/apache/orc/pull/912#issuecomment-920769192


   Thank you so much, @guiyanakuang !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #912: ORC-1002: Add `java17` profile to support Java 17 unit testing

Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #912:
URL: https://github.com/apache/orc/pull/912#issuecomment-920773118


   > In the community, the written approval(LGTM) is important.
   
   I get it. Thanks to @dongjoon-hyun  for the urgent adaption of JDK17. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #912: ORC-1002: Add `java17` profile to support Java 17 unit testing

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #912:
URL: https://github.com/apache/orc/pull/912#issuecomment-920746250


   Could you review this, @guiyanakuang ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #912: ORC-1002: Add `java17` profile to support Java 17 unit testing

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #912:
URL: https://github.com/apache/orc/pull/912#issuecomment-920751903


   It's already handled here.
   - https://github.com/apache/orc/pull/912/files#diff-d8225ebcfc11b480a6e4f54e183b67c3ead51635a167c106d928c2abf1f9ef66R468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #912: ORC-1002: Add `java17` profile to support Java 17 unit testing

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #912:
URL: https://github.com/apache/orc/pull/912#issuecomment-920766770


   Thank you for checking. Then, if you think this PR looks good to you, could you approve this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #912: ORC-1002: Add `java17` profile to support Java 17 unit testing

Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #912:
URL: https://github.com/apache/orc/pull/912#issuecomment-920751046


   > Could you review this, @guiyanakuang ?
   > 
   > * You can test it manually with Java 17.
   > * For GitHub Action CI, I'll handle separately.
   
   orc-mapreduce/pom.xml 76-81
   Specified minimum version，need to fix.
   ```
       <dependency>
         <groupId>org.apache.hadoop</groupId>
         <artifactId>hadoop-mapreduce-client-jobclient</artifactId>
         <version>${min.hadoop.version}</version>
         <scope>test</scope>
       </dependency>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun edited a comment on pull request #912: ORC-1002: Add `java17` profile to support Java 17 unit testing

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #912:
URL: https://github.com/apache/orc/pull/912#issuecomment-920746250


   Could you review this, @guiyanakuang ?
   - You can test it manually with Java 17.
   - For GitHub Action CI, I'll handle separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #912: ORC-1002: Add `java17` profile to support Java 17 unit testing

Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #912:
URL: https://github.com/apache/orc/pull/912#issuecomment-920768746


   +1 LGTM. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #912: ORC-1002: Add java17 profile for Java17 unit testing

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #912:
URL: https://github.com/apache/orc/pull/912#discussion_r709951801



##########
File path: java/shims/pom.xml
##########
@@ -95,5 +95,15 @@
         <directory>${build.dir}/shims</directory>
       </build>
     </profile>
+    <profile>
+      <id>java17</id>
+      <dependencies>
+        <dependency>
+          <groupId>org.apache.hadoop</groupId>
+          <artifactId>hadoop-client-api</artifactId>
+          <version>${hadoop.version}</version>

Review comment:
       Note that this is the only `compile` dependency. The other places are `test` dependency.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #912: ORC-1002: Add `java17` profile to support Java 17 unit testing

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #912:
URL: https://github.com/apache/orc/pull/912


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #912: ORC-1002: Add `java17` profile to support Java 17 unit testing

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #912:
URL: https://github.com/apache/orc/pull/912#issuecomment-920769497


   In the community, the written approval(LGTM) is important.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #912: ORC-1002: Add `java17` profile to support Java 17 unit testing

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #912:
URL: https://github.com/apache/orc/pull/912#issuecomment-920763159


   Do you hit any failure, @guiyanakuang ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #912: ORC-1002: Add `java17` profile to support Java 17 unit testing

Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #912:
URL: https://github.com/apache/orc/pull/912#issuecomment-920764152


   @dongjoon-hyun  Build and test run fine in my Mac.
   ```
   /Library/Java/JavaVirtualMachines/openjdk-17/Contents/Home/bin/java 
   .....
   [INFO] Reactor Summary for Apache ORC 1.8.0-SNAPSHOT:
   [INFO] 
   [INFO] Apache ORC ......................................... SUCCESS [  2.556 s]
   [INFO] ORC Shims .......................................... SUCCESS [  9.378 s]
   [INFO] ORC Core ........................................... SUCCESS [02:00 min]
   [INFO] ORC MapReduce ...................................... SUCCESS [ 39.114 s]
   [INFO] ORC Tools .......................................... SUCCESS [ 26.676 s]
   [INFO] ORC Examples ....................................... SUCCESS [  9.885 s]
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  03:28 min
   [INFO] Finished at: 2021-09-16T18:01:30+08:00
   [INFO] ------------------------------------------------------------------------
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org