[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #5083: Prevent changing DS fields that would invalidate its SSL key

[GitBox <gi...@apache.org>]

shamrickus commented on a change in pull request #5083:
URL: https://github.com/apache/trafficcontrol/pull/5083#discussion_r497752840



##########
File path: traffic_portal/app/src/common/modules/form/deliveryService/edit/FormEditDeliveryServiceController.js
##########
@@ -161,6 +166,30 @@ var FormEditDeliveryServiceController = function(deliveryService, origin, topolo
 	};
 
 	$scope.save = function(deliveryService) {
+		if (deliveryService.sslKeyVersion !== null && deliveryService.sslKeyVersion !== 0 &&

Review comment:
       From my testing, the ssl_key_version on the deliveryservice table is always updated when the ssl keys are changed/created. Also the /deliveryserivces endpoint does return that field as `sslKeyVersion`. Inspecting the network call in TP when loading the DS table, each DS has it's `sslKeyVersion` returned.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org