You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/31 14:32:49 UTC
[GitHub] [calcite] Technay commented on a change in pull request #1544:
[CALCITE-3415] Supports REGEXP_SUBSTR function
Technay commented on a change in pull request #1544: [CALCITE-3415] Supports REGEXP_SUBSTR function
URL: https://github.com/apache/calcite/pull/1544#discussion_r341040725
##########
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
##########
@@ -1762,6 +1762,8 @@ public SqlSyntax getSyntax() {
public static final SqlFunction NULLIF = new SqlNullifFunction();
+ public static final SqlFunction REGEXP_SUBSTR = new SqlRegexpSubstrFunction();
+
Review comment:
As mentioned before https://issues.apache.org/jira/browse/CALCITE-3415?focusedCommentId=16952641&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16952641, it is present in most of the major dialects such as MySql, Oracle, Teradata. Kindly let me know your thoughts on whether it should be added to SqlStdOperatorTable or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services