You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mindlesscloud (via GitHub)" <gi...@apache.org> on 2023/05/10 08:00:40 UTC
[GitHub] [incubator-devlake] mindlesscloud opened a new pull request, #5147: fix: the overflow error of _tool_jira_remotelinks.self
mindlesscloud opened a new pull request, #5147:
URL: https://github.com/apache/incubator-devlake/pull/5147
### Summary
Fix the DB overflow error by changing the type of `_tool_jira_remotelinks.self` from `VARCHAR(255)` to `LONGTEXT`
Now the schema looks like:
```SQL
CREATE TABLE _tool_jira_remotelinks (
created_at timestamp with time zone,
updated_at timestamp with time zone,
_raw_data_params character varying(255),
_raw_data_table character varying(255),
_raw_data_id bigint,
_raw_data_remark text,
connection_id bigint,
remotelink_id bigint,
issue_id bigint,
raw_json jsonb,
title text,
issue_updated timestamp with time zone,
url text,
self text,
CONSTRAINT _tool_jira_remotelinks_pkey PRIMARY KEY (connection_id, remotelink_id)
);
```
### Does this close any open issues?
Closes #5146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #5147: fix: the overflow error of _tool_jira_remotelinks.self
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on code in PR #5147:
URL: https://github.com/apache/incubator-devlake/pull/5147#discussion_r1189524777
##########
backend/plugins/jira/models/migrationscripts/20230510_expand_remotelink_selfurl.go:
##########
@@ -0,0 +1,69 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package migrationscripts
+
+import (
+ "github.com/apache/incubator-devlake/core/context"
+ "github.com/apache/incubator-devlake/core/dal"
+ "github.com/apache/incubator-devlake/core/errors"
+ "github.com/apache/incubator-devlake/core/plugin"
+ "github.com/apache/incubator-devlake/helpers/migrationhelper"
+)
+
+var _ plugin.MigrationScript = (*expandRemotelinkUrl)(nil)
+
+type jiraRemotelink20230510 struct {
+ Self string
Review Comment:
gorm:"type:text"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #5147: fix: the overflow error of _tool_jira_remotelinks.self
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on code in PR #5147:
URL: https://github.com/apache/incubator-devlake/pull/5147#discussion_r1189524777
##########
backend/plugins/jira/models/migrationscripts/20230510_expand_remotelink_selfurl.go:
##########
@@ -0,0 +1,69 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package migrationscripts
+
+import (
+ "github.com/apache/incubator-devlake/core/context"
+ "github.com/apache/incubator-devlake/core/dal"
+ "github.com/apache/incubator-devlake/core/errors"
+ "github.com/apache/incubator-devlake/core/plugin"
+ "github.com/apache/incubator-devlake/helpers/migrationhelper"
+)
+
+var _ plugin.MigrationScript = (*expandRemotelinkUrl)(nil)
+
+type jiraRemotelink20230510 struct {
+ Self string
Review Comment:
string -> text?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #5147: fix: the overflow error of _tool_jira_remotelinks.self
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on code in PR #5147:
URL: https://github.com/apache/incubator-devlake/pull/5147#discussion_r1189524777
##########
backend/plugins/jira/models/migrationscripts/20230510_expand_remotelink_selfurl.go:
##########
@@ -0,0 +1,69 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package migrationscripts
+
+import (
+ "github.com/apache/incubator-devlake/core/context"
+ "github.com/apache/incubator-devlake/core/dal"
+ "github.com/apache/incubator-devlake/core/errors"
+ "github.com/apache/incubator-devlake/core/plugin"
+ "github.com/apache/incubator-devlake/helpers/migrationhelper"
+)
+
+var _ plugin.MigrationScript = (*expandRemotelinkUrl)(nil)
+
+type jiraRemotelink20230510 struct {
+ Self string
Review Comment:
varchar -> text?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn merged pull request #5147: fix: the overflow error of _tool_jira_remotelinks.self
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #5147:
URL: https://github.com/apache/incubator-devlake/pull/5147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org