You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/02/29 09:10:37 UTC
[GitHub] [pulsar] gaoran10 opened a new pull request #6445: Fix avro schema
decode error in functions
gaoran10 opened a new pull request #6445: Fix avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445
Fixes #5503
### Motivation
In functions, it will encounter ```ClassCastException``` when using the Avro schema for topics.
```
Exception in thread "main" java.lang.ClassCastException: org.apache.pulsar.shade.org.apache.avro.generic.GenericData$Record cannot be cast to io.streamnative.KeyValueSchemaTest$Foo2
at io.streamnative.KeyValueSchemaTest.testConsumerByPythonProduce(KeyValueSchemaTest.java:412)
at io.streamnative.KeyValueSchemaTest.main(KeyValueSchemaTest.java:305)
```
### Modifications
In functions, when using Avro schema specific the ```ClassLoader``` for ```ReflectDatumReader```.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-607603989
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-608525247
This fork repository is deleted by mistake, so make a new fork and take this PR to #6662.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-607958718
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-600396679
@gaoran10 can you check the integration tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-605550055
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-606151406
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-608037865
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-606975032
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-599332464
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
tuteng commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-600587850
@gaoran10 Please try to rebase master for pass the test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-600396596
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-607854212
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-607926711
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-606880626
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-606757682
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 opened a new pull request #6445: Fixed avro
schema decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 opened a new pull request #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445
Fixes #5503
### Motivation
In functions, it will encounter ```ClassCastException``` when using the Avro schema for topics.
```
Exception in thread "main" java.lang.ClassCastException: org.apache.pulsar.shade.org.apache.avro.generic.GenericData$Record cannot be cast to io.streamnative.KeyValueSchemaTest$Foo2
at io.streamnative.KeyValueSchemaTest.testConsumerByPythonProduce(KeyValueSchemaTest.java:412)
at io.streamnative.KeyValueSchemaTest.main(KeyValueSchemaTest.java:305)
```
### Modifications
In functions, when using Avro schema specific the ```ClassLoader``` for ```ReflectDatumReader```.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-605968028
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #6445: Fixed
avro schema decode error in functions
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#discussion_r386054716
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java
##########
@@ -88,14 +97,19 @@ public boolean supportSchemaVersioning() {
return new AvroSchema<>(parseSchemaInfo(schemaDefinition, SchemaType.AVRO));
}
+ public static <T> AvroSchema<T> ofWithClass(SchemaDefinition<T> schemaDefinition) {
Review comment:
Do we need a separate static method? Why can we just check if schemaDefinition has POJO? If it has POJO, when we create a schema instance, we should include the POJO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-605435761
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 opened a new pull request #6445: Fixed avro
schema decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 opened a new pull request #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445
Fixes #5503
### Motivation
In functions, it will encounter ```ClassCastException``` when using the Avro schema for topics.
```
Exception in thread "main" java.lang.ClassCastException: org.apache.pulsar.shade.org.apache.avro.generic.GenericData$Record cannot be cast to io.streamnative.KeyValueSchemaTest$Foo2
at io.streamnative.KeyValueSchemaTest.testConsumerByPythonProduce(KeyValueSchemaTest.java:412)
at io.streamnative.KeyValueSchemaTest.main(KeyValueSchemaTest.java:305)
```
### Modifications
In functions, when using Avro schema specific the ```ClassLoader``` for ```ReflectDatumReader```.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-602325004
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-600971629
@sijie Ok, I will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-606958770
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 closed pull request #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 closed pull request #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-601979113
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-607794544
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-599449621
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-607635482
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-605416658
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-607405066
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
tuteng commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-601499351
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on a change in pull request #6445:
Fixed avro schema decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#discussion_r386089300
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java
##########
@@ -88,14 +97,19 @@ public boolean supportSchemaVersioning() {
return new AvroSchema<>(parseSchemaInfo(schemaDefinition, SchemaType.AVRO));
}
+ public static <T> AvroSchema<T> ofWithClass(SchemaDefinition<T> schemaDefinition) {
Review comment:
Yes, it's more reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-602056413
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-608422985
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-601723403
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-607366470
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] tuteng closed pull request #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
tuteng closed pull request #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-606995812
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-601647207
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 opened a new pull request #6445: Fixed avro
schema decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 opened a new pull request #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445
Fixes #5503
### Motivation
In functions, it will encounter ```ClassCastException``` when using the Avro schema for topics.
```
Exception in thread "main" java.lang.ClassCastException: org.apache.pulsar.shade.org.apache.avro.generic.GenericData$Record cannot be cast to io.streamnative.KeyValueSchemaTest$Foo2
at io.streamnative.KeyValueSchemaTest.testConsumerByPythonProduce(KeyValueSchemaTest.java:412)
at io.streamnative.KeyValueSchemaTest.main(KeyValueSchemaTest.java:305)
```
### Modifications
In functions, when using Avro schema specific the ```ClassLoader``` for ```ReflectDatumReader```.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-606011846
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 closed pull request #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 closed pull request #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-606800759
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-606671296
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-605806389
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
tuteng commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-600942285
@gaoran10 You can try command:
```
mvn clean install -DskipTests
mvn -B -f tests/docker-images/pom.xml install -am -Pdocker -DskipTests
mvn -B -f tests/pom.xml test -DintegrationTestSuiteFile=pulsar-process.xml -DintegrationTests -DredirectTestOutputToFile=false -Dgroups=function
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-605735732
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 closed pull request #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 closed pull request #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 removed a comment on issue #6445: Fixed avro
schema decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 removed a comment on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-600971256
> @gaoran10 can you check the integration tests?
ok, i will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-602262493
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-605894479
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-607560469
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-607586879
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 opened a new pull request #6445: Fixed avro
schema decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 opened a new pull request #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445
Fixes #5503
### Motivation
In functions, it will encounter ```ClassCastException``` when using the Avro schema for topics.
```
Exception in thread "main" java.lang.ClassCastException: org.apache.pulsar.shade.org.apache.avro.generic.GenericData$Record cannot be cast to io.streamnative.KeyValueSchemaTest$Foo2
at io.streamnative.KeyValueSchemaTest.testConsumerByPythonProduce(KeyValueSchemaTest.java:412)
at io.streamnative.KeyValueSchemaTest.main(KeyValueSchemaTest.java:305)
```
### Modifications
In functions, when using Avro schema specific the ```ClassLoader``` for ```ReflectDatumReader```.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-600971256
> @gaoran10 can you check the integration tests?
ok, i will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-606838376
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-607579696
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 closed pull request #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 closed pull request #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-607400310
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
tuteng commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-601634629
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-600971743
@tuteng Thanks, I will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] gaoran10 commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-607881924
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6445: Fixed avro schema decode
error in functions
Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-602132751
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-605617982
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #6445: Fixed avro schema
decode error in functions
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#issuecomment-602312269
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services