You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Mark Struberg <st...@yahoo.de> on 2010/09/08 11:16:48 UTC

Re: svn commit: r993621 - /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java

Gurkan, PLEEEASSE profile this checkin and then REVERT IT AGAIN!

There is a reason why I commented it clearly!
This is a passage which will get used MILLIONS of times in a second!

This will slow down OWB HEAVILY in all situations where we do not log to jul directly but have a logging bridge involved like with Geronimo which uses pax logging!

ALSO: PLEASE ONLY CHECKIN WITH A JIRA!

LieGrue,
strub

--- On Wed, 9/8/10, gerdogdu@apache.org <ge...@apache.org> wrote:

> From: gerdogdu@apache.org <ge...@apache.org>
> Subject: svn commit: r993621 - /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
> To: commits@openwebbeans.apache.org
> Date: Wednesday, September 8, 2010, 6:10 AM
> Author: gerdogdu
> Date: Wed Sep  8 06:10:18 2010
> New Revision: 993621
> 
> URL: http://svn.apache.org/viewvc?rev=993621&view=rev
> Log:
> Check Log level before logging.
> 
> Modified:
>    
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
> 
> Modified:
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
> URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java?rev=993621&r1=993620&r2=993621&view=diff
> ==============================================================================
> ---
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
> (original)
> +++
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
> Wed Sep  8 06:10:18 2010
> @@ -187,8 +187,12 @@ public abstract class
> InterceptorHandler
>              
>          
>    if(ClassUtil.isObjectMethod(methodName)
> && !methodName.equals("toString"))
>              {
> -                //
> we must not log in this place because this almost takes away
> half of the performance! 
> -                //
> logger.trace("Calling method on proxy is restricted except
> Object.toString(), but current method is Object. [{0}]",
> methodName);
> +                //
> we must not log in this place because this almost takes away
> half of the performance!
> +               
> //GE : Log on TRACE Level
> +               
> if(logger.wblWillLogTrace())
> +                {
> +               
>     logger.trace("Calling method on proxy is
> restricted except Object.toString(), but current method is
> Object. [{0}]", methodName);   
> +                }
>              }
>              
>              else
> if (bean instanceof InjectionTargetBean<?>)
> 
> 
> 


      

Re: svn commit: r993621 - /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java

Posted by Mark Struberg <st...@yahoo.de>.
Heh sorry for the capitals ;) But this special logging really costs 30% of the whole performance of an application under geronimo, because the log-condition check itself is already pretty expensive :(
It's too bad that there is no #ifdef DEBUG in Java... ;)

LieGrue,
strub

--- On Wed, 9/8/10, Gurkan Erdogdu <gu...@yahoo.com> wrote:

> From: Gurkan Erdogdu <gu...@yahoo.com>
> Subject: Re: svn commit: r993621 - /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
> To: dev@openwebbeans.apache.org
> Date: Wednesday, September 8, 2010, 10:46 AM
> Hello Mark,
> 
> This is why I put conditional check for TRACE. 
> 
> 
> I think this commit does not need JIRA. But if you still
> under angry with this 
> commit, you can revert it. But, lots of message brokers
> uses LOGs in their 
> millions of second message consuming. I know that logging
> in somehow drop 
> performance but this is ineviatable!
> 
> No need to use CAPITAL words! :)
> 
> 
> Thanks;
> 
> --Gurkan
> 
> 
> ________________________________
> From: Mark Struberg <st...@yahoo.de>
> To: dev@openwebbeans.apache.org
> Sent: Wed, September 8, 2010 12:16:48 PM
> Subject: Re: svn commit: r993621 - 
> /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
> 
> 
> Gurkan, PLEEEASSE profile this checkin and then REVERT IT
> AGAIN!
> 
> There is a reason why I commented it clearly!
> This is a passage which will get used MILLIONS of times in
> a second!
> 
> This will slow down OWB HEAVILY in all situations where we
> do not log to jul 
> directly but have a logging bridge involved like with
> Geronimo which uses pax 
> logging!
> 
> ALSO: PLEASE ONLY CHECKIN WITH A JIRA!
> 
> LieGrue,
> strub
> 
> --- On Wed, 9/8/10, gerdogdu@apache.org
> <ge...@apache.org>
> wrote:
> 
> > From: gerdogdu@apache.org
> <ge...@apache.org>
> > Subject: svn commit: r993621 - 
> >/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
> >
> > To: commits@openwebbeans.apache.org
> > Date: Wednesday, September 8, 2010, 6:10 AM
> > Author: gerdogdu
> > Date: Wed Sep  8 06:10:18 2010
> > New Revision: 993621
> > 
> > URL: http://svn.apache.org/viewvc?rev=993621&view=rev
> > Log:
> > Check Log level before logging.
> > 
> > Modified:
> >    
> >openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
> >a
> > 
> > Modified:
> >openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
> >a
> > URL: 
> >http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java?rev=993621&r1=993620&r2=993621&view=diff
> >
> >
> ==============================================================================
> > ---
> >openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
> >a
> > (original)
> > +++
> >openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
> >a
> > Wed Sep  8 06:10:18 2010
> > @@ -187,8 +187,12 @@ public abstract class
> > InterceptorHandler
> >              
> >          
> >    if(ClassUtil.isObjectMethod(methodName)
> > && !methodName.equals("toString"))
> >              {
> > -             
>   //
> > we must not log in this place because this almost
> takes away
> > half of the performance! 
> > -             
>   //
> > logger.trace("Calling method on proxy is restricted
> except
> > Object.toString(), but current method is Object.
> [{0}]",
> > methodName);
> > +             
>   //
> > we must not log in this place because this almost
> takes away
> > half of the performance!
> > +           
>    
> > //GE : Log on TRACE Level
> > +           
>    
> > if(logger.wblWillLogTrace())
> > +             
>   {
> > +           
>    
> >     logger.trace("Calling method
> on proxy is
> > restricted except Object.toString(), but current
> method is
> > Object. [{0}]", methodName);   
> > +             
>   }
> >              }
> >              
> >              else
> > if (bean instanceof InjectionTargetBean<?>)
> > 
> > 
> > 
> 
> 


      

Re: svn commit: r993621 - /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java

Posted by Gurkan Erdogdu <gu...@yahoo.com>.
Hello Mark,

This is why I put conditional check for TRACE. 


I think this commit does not need JIRA. But if you still under angry with this 
commit, you can revert it. But, lots of message brokers uses LOGs in their 
millions of second message consuming. I know that logging in somehow drop 
performance but this is ineviatable!

No need to use CAPITAL words! :)


Thanks;

--Gurkan


________________________________
From: Mark Struberg <st...@yahoo.de>
To: dev@openwebbeans.apache.org
Sent: Wed, September 8, 2010 12:16:48 PM
Subject: Re: svn commit: r993621 - 
/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java


Gurkan, PLEEEASSE profile this checkin and then REVERT IT AGAIN!

There is a reason why I commented it clearly!
This is a passage which will get used MILLIONS of times in a second!

This will slow down OWB HEAVILY in all situations where we do not log to jul 
directly but have a logging bridge involved like with Geronimo which uses pax 
logging!

ALSO: PLEASE ONLY CHECKIN WITH A JIRA!

LieGrue,
strub

--- On Wed, 9/8/10, gerdogdu@apache.org <ge...@apache.org> wrote:

> From: gerdogdu@apache.org <ge...@apache.org>
> Subject: svn commit: r993621 - 
>/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
>
> To: commits@openwebbeans.apache.org
> Date: Wednesday, September 8, 2010, 6:10 AM
> Author: gerdogdu
> Date: Wed Sep  8 06:10:18 2010
> New Revision: 993621
> 
> URL: http://svn.apache.org/viewvc?rev=993621&view=rev
> Log:
> Check Log level before logging.
> 
> Modified:
>    
>openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
>a
> 
> Modified:
>openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
>a
> URL: 
>http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java?rev=993621&r1=993620&r2=993621&view=diff
>
> ==============================================================================
> ---
>openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
>a
> (original)
> +++
>openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java
>a
> Wed Sep  8 06:10:18 2010
> @@ -187,8 +187,12 @@ public abstract class
> InterceptorHandler
>              
>          
>    if(ClassUtil.isObjectMethod(methodName)
> && !methodName.equals("toString"))
>              {
> -                //
> we must not log in this place because this almost takes away
> half of the performance! 
> -                //
> logger.trace("Calling method on proxy is restricted except
> Object.toString(), but current method is Object. [{0}]",
> methodName);
> +                //
> we must not log in this place because this almost takes away
> half of the performance!
> +               
> //GE : Log on TRACE Level
> +               
> if(logger.wblWillLogTrace())
> +                {
> +               
>     logger.trace("Calling method on proxy is
> restricted except Object.toString(), but current method is
> Object. [{0}]", methodName);   
> +                }
>              }
>              
>              else
> if (bean instanceof InjectionTargetBean<?>)
> 
> 
>