You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/12/01 22:42:29 UTC

Review Request 54268: geode-2137 client membership IDs contain 17 bytes of useless information

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54268/
-----------------------------------------------------------

Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: GEODE-2137
    https://issues.apache.org/jira/browse/GEODE-2137


Repository: geode


Description
-------

There was a problem with the previous fix for this issue.  toData and fromData methods in InternalDistributedMember also need to look at the version of the data stream in order to decide whether to send the UUID bytes or not.


Diffs
-----

  geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java 3404495 

Diff: https://reviews.apache.org/r/54268/diff/


Testing
-------

integration testing
precheckin


Thanks,

Bruce Schuchardt


Re: Review Request 54268: geode-2137 client membership IDs contain 17 bytes of useless information

Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54268/#review157665
-----------------------------------------------------------


Ship it!




Ship It!

- Hitesh Khamesra


On Dec. 1, 2016, 10:42 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54268/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2016, 10:42 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2137
>     https://issues.apache.org/jira/browse/GEODE-2137
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> There was a problem with the previous fix for this issue.  toData and fromData methods in InternalDistributedMember also need to look at the version of the data stream in order to decide whether to send the UUID bytes or not.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java 3404495 
> 
> Diff: https://reviews.apache.org/r/54268/diff/
> 
> 
> Testing
> -------
> 
> integration testing
> precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>