You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/01/30 03:21:05 UTC

[kudu-CR] Fix flakiness in create-table-itest

Hello Binglin Chang, Mike Percy,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/1971

to review the following change.

Change subject: Fix flakiness in create-table-itest
......................................................................

Fix flakiness in create-table-itest

This fixes a flaky test introduced in c5d748198df48007b2a6fe07c2a214a885fc41ee.
The test was flaky because tablet deletion is asynchronous and can actually
take a substantial amount of time since it does file system operations. Since
RPCs aren't counted in a metric until they're complete, it was possible for
multiple replicas to get created before any of them got deleted.

This patch just changes the verification mechanism to ensure that the tablet
server eventually converges to the correct state.

I looped the new test 100 times and it passed:
http://dist-test.cloudera.org/job?job_id=todd.1454117343.9201

Change-Id: I25ed27a9cf0b4539b6e7a056a2d5c8872e3c1860
---
M src/kudu/integration-tests/create-table-itest.cc
1 file changed, 22 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/1971/1
-- 
To view, visit http://gerrit.cloudera.org:8080/1971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I25ed27a9cf0b4539b6e7a056a2d5c8872e3c1860
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Binglin Chang <de...@gmail.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>